1131642 - css keyframes animation name missing in the rule-view

Status: RESOLVED WORKSFORME

(DevTools :: Inspector, defect)

Description

[Patrick Brosset <:pbro>]

Attachment: Screenshot 2015-02-10 16.32.08.png

The rule-view shows the @keyframes rule when there is a css animation applied to the current node in the inspector.
It shows it in a separate section at the end of the rule-view.

It looks like there was a regression with this feature, because the animation name is supposed to appear in the section header, but not it shows "Inherited from" instead.

Comment 1

[Patrick Brosset <:pbro>]

It seems to only occur on dev-edition.
I will attach a test page and STR.

Comment 2

[Patrick Brosset <:pbro>]

Attachment: animation.html

STR
- open the attached test page in dev-edition
- open the inspector
- select the .simple-animation node
- check the rule-view

Comment 3

[Patrick Brosset <:pbro>]

If I select the .multiple-animations node instead, I see the 2 expected keyframes sections, but only one has the right section header.

Comment 4

[Patrick Brosset <:pbro>]

Attachment: keyframes.gif

Here's an animated gif showing what I see on the test page.

Comment 5

[Patrick Brosset <:pbro>]

I did a little debugging and found out that the keyframes section header is created correctly when createExpandableContainer is called [1], but it gets replaced with an incorrect header when the CssRuleViewRefreshed event gets dispatched [2].

[1] http://mxr.mozilla.org/mozilla-central/source/browser/devtools/styleinspector/rule-view.js#1811
[2] http://mxr.mozilla.org/mozilla-central/source/browser/devtools/styleinspector/rule-view.js#1616

Comment 6

[Julian Descottes [:jdescottes]]

Inspector bug triage. Filter on CLIMBING SHOES.

Cannot reproduce the issue described in the STRs. 
For .simple-animation the header of the rule view section has the expected title : "Keyframes move"