Closed Bug 1131829 Opened 9 years ago Closed 9 years ago

promiseUtils.resolveOrTimeout should be removed.

Categories

(Toolkit :: Async Tooling, defect)

Product:
Toolkit
Component:
Async Tooling
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla38
Iteration:
38.3 - 23 Feb
Tracking Flags:
Tracking Status
firefox38 --- fixed

People

(Reporter: markh, Assigned: markh)

References

Details

Attachments

(1 file)

0001-Bug-1131829-remove-PromiseUtils.resolveOrTimeout.-r-.patch
7.03 KB, patch
Yoric
: review+
Details | Diff | Splinter Review 
PromiseUtils.resolveOrTimeout has no callers in the tree and no identified use-case.  The bug that implemented it does describe a potentially useful function (bug 1080466 comment 1), but the implementation doesn't do that.  See also bug 1080466 comment 33.

No callers in the 3 months it's been in the tree and no identified use-case implies we should just remove it.
No objection. We can re-add it if it becomes useful again.
Attachment #8563023 - Flags: review?(dteller) → review+
https://hg.mozilla.org/integration/fx-team/rev/463ff2bdf8fb
Assignee: nobody → mhammond
Status: NEW → ASSIGNED
Iteration: --- → 38.3 - 23 Feb
Points: --- → 1
Flags: qe-verify-
Flags: firefox-backlog+
https://hg.mozilla.org/mozilla-central/rev/463ff2bdf8fb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox38: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
See Also: → 1308395
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: