113213 - Recent printing changes break QT port

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[hacker formerly known as [e-mail]]

Building the QT port fails because nsIDeviceContextSpecPS::GetPrinter() is not
implemented for the concrete QT class.

Comment 1

[hacker formerly known as [e-mail]]

Attachment: Get QT compiling again

Comment 2

[Jerome Lacoste]

By the way, some clean-up could be done in the nsDeviceContextSpecQT.cpp file:
- Indentation is not that great: it does not render well on lxr.
(http://lxr.mozilla.org/seamonkey/source/gfx/src/qt/nsDeviceContextSpecQT.cpp)
- lines 260-265 could perhaps be moved up in the code, as 
  1- they are not really usefull at this place in the code (appart from the test
line 251)
  2- line 258, the return may create leaks, and if it doens't yet, any change to
the code may be a risk to create one.

Perhaps I didn't read the code correctly as indentation in LXR is bad and I may
have counted bracets incorrectly...

Comment 3

[Roland Mainz]

Comment on attachment 60136 [details] [diff] [review]
Get QT compiling again

r=[e-mail]

Comment 4

[hacker formerly known as [e-mail]]

Patch has been checked in.

Comment 5

[Jerome Lacoste]

What about the cleanup mentioned in comment #3, should I open a new bug?

Comment 6

[Roland Mainz]

Jerome Lacoste:
> What about the cleanup mentioned in comment #3, should I open a new bug?

Yes, please. And don't forget to CC: me... :)

Comment 7

[sujay]

Chris/Roland, can one of you please verify this fix and mark this bug
VERIFIED-FIXED ? thanks..

Comment 8

[hacker formerly known as [e-mail]]

Verified.