1132141 - Update storage when ServiceWorker registration fails.

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

If register() fails, remove the registration we've persisted.

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: Update storage when ServiceWorker registration fails

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8562929 [details] [diff] [review]
Update storage when ServiceWorker registration fails

Review of attachment 8562929 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/ServiceWorkerManager.cpp
@@ +2416,5 @@
> +{
> +  MOZ_ASSERT(aRegistration);
> +  MOZ_ASSERT(!aRegistration->IsControllingDocuments());
> +  MOZ_ASSERT(mServiceWorkerRegistrationInfos.Contains(aRegistration->mScope));
> +  ServiceWorkerManager::RemoveScope(mOrderedScopes, aRegistration->mScope);

you don't need ServiceWorkerManager:: right?

@@ +2436,5 @@
> +  PrincipalInfo principalInfo;
> +  if (NS_WARN_IF(NS_FAILED(PrincipalToPrincipalInfo(reg->mPrincipal,
> +                                                    &principalInfo)))) {
> +    //XXXnsm I can't think of any other reason a stored principal would fail to
> +    //convert.

then just do:
NS_ALWAYS_TRUE(NS_SUCCEEDED(PrincipalToPrincipalInfo(...

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ebbc5550931

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2ebbc5550931