Closed
Bug 113243
Opened 23 years ago
Closed 20 years ago
Get rid of (Compare|Equals)WithConversion
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla1.8alpha3
People
(Reporter: jag+mozilla, Assigned: Biesinger)
References
Details
Attachments
(2 files)
11.99 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
3.81 KB,
patch
|
darin.moz
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
Replace them with the appropriate Compare / Equals and convertors. We can later look into using generators for these, which could do on-demand character conversions as the search algorithm asks for them. We'd have to expand string generators though to support this.
Reporter | ||
Comment 1•23 years ago
|
||
The second sweep of this would benefit from bug 114386.
Assignee | ||
Comment 3•20 years ago
|
||
note: this patch only kills callers of equals/comparewithconversion
Assignee: jag → cbiesinger
Status: NEW → ASSIGNED
Assignee | ||
Updated•20 years ago
|
Attachment #153716 -
Flags: review?(roc)
Attachment #153716 -
Flags: superreview+
Attachment #153716 -
Flags: review?(roc)
Attachment #153716 -
Flags: review+
Assignee | ||
Updated•20 years ago
|
Attachment #153716 -
Attachment description: patch for callers → patch for callers (checked in)
Assignee | ||
Comment 4•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Attachment #153945 -
Flags: review?(darin)
Assignee | ||
Updated•20 years ago
|
Target Milestone: Future → mozilla1.8alpha3
Updated•20 years ago
|
Attachment #153945 -
Flags: review?(darin) → review+
Assignee | ||
Updated•20 years ago
|
Attachment #153945 -
Flags: superreview?(dbaron)
Attachment #153945 -
Flags: superreview?(dbaron) → superreview+
Assignee | ||
Comment 5•20 years ago
|
||
Checking in public/nsTString.h; /cvsroot/mozilla/xpcom/string/public/nsTString.h,v <-- nsTString.h new revision: 1.15; previous revision: 1.14 done Checking in src/nsStringObsolete.cpp; /cvsroot/mozilla/xpcom/string/src/nsStringObsolete.cpp,v <-- nsStringObsolete.cpp new revision: 1.13; previous revision: 1.12 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•