1132924 - XHR.response crashes if the response is an empty string.

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: xhr.patch

Of course this happens just in debug builds.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8564166 [details] [diff] [review]
xhr.patch

Review of attachment 8564166 [details] [diff] [review]:
-----------------------------------------------------------------

As far as I can tell from the spec, this is allowed.  For example, see here:

  https://xhr.spec.whatwg.org/#text-response

Please include the empty.html file as well.  Thanks!

Comment 3

[Andrea Marchesini [:baku]]

Attachment: xhr.patch

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8564175 [details] [diff] [review]
xhr.patch

Sorry guys, removing the assertion isn't quite right. If the string is empty we need to use JS_GetEmptyStringValue, not create a new empty string.

Comment 5

[Andrea Marchesini [:baku]]

Attachment: xhr.patch

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8564189 [details] [diff] [review]
xhr.patch

Thanks!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Please provide a Try link.

Comment 8

[Andrea Marchesini [:baku]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e1f154f0341

If you see some b2g serviceWorker failure, this is related to a patch included in this push.
It's not related to this patch.

Comment 9

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/41aa3bdc7e75

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/41aa3bdc7e75