Closed Bug 1132929 Opened 9 years ago Closed 9 years ago

[Accessibility] Fix visibility issues in video app.

Categories

(Firefox OS Graveyard :: Gaia::Video, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Video
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S6 (20feb)
Tracking Flags:
Tracking Status
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: yzen, Assigned: yzen)

References

Details

(Whiteboard: [b2ga11y p=1])

Attachments

(1 file, 1 obsolete file)

[gaia] yzen:bug-1132929 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
rnicoletti
: review+
bajaj
: approval-gaia-v2.2+
Details | Review 
When an overlay dialog is displayed, it should be elusively visible and rest of the content has to be explicitly hidden, otherwise the screen reader user will be able to get to navigate to it.
Also screen reader can access #picker-header when not performing a pick activity. That would need to be fixed.
Summary: [Accessibility] Fix visibility issues around overlays in video app. → [Accessibility] Fix visibility issues in video app.
Attached file Github pull request. (obsolete) — 

        Attachment #8564276 -
        Flags: review?(rnicoletti)

        Attachment #8564276 -
        Attachment is obsolete: true

        Attachment #8564276 -
        Flags: review?(rnicoletti)

        Attachment #8564275 -
        Flags: review?(rnicoletti)
Whiteboard: [b2ga11y p=1]

    
    

    
  
Comment on attachment 8564275 [details] [review]
[gaia] yzen:bug-1132929 > mozilla-b2g:master

The changes look good. I added one nit in the PR comments.

        Attachment #8564275 -
        Flags: review?(rnicoletti) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 8564275 [details] [review]
[gaia] yzen:bug-1132929 > mozilla-b2g:master

[Approval Request Comment] This PR fixes issues with visibility around the Video app for screen reader users
[Bug caused by] (feature/regressing bug #): improvement, not a bug
[User impact] if declined: If declined the screen reader user will be able to access views that are not visible to users otherwise.
[Testing completed]: on device
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none

        Attachment #8564275 -
        Flags: approval-gaia-v2.2?

        Attachment #8564275 -
        Flags: approval-gaia-v2.2? → approval-gaia-v2.2+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: