1133139 - Show a warning when the binary component cannot be loaded

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Another big release is coming up and we still have libical. It's again likely that some people will manage to install a mismatching Lightning version. This patch at least tells the user what went wrong, instead of leaving him alone with a broken view.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Comment 2

[Mohit Kanwal [:redDragon]]

Comment on attachment 8564420 [details] [diff] [review]
Fix - v1

Review of attachment 8564420 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

::: calendar/lightning/content/messenger-overlay-sidebar.js
@@ +506,5 @@
> +    const THUNDERBIRD_GUID = "{3550f703-e582-4d05-9a08-453d09bdfdc6}";
> +    const SEAMONKEY_GUID = "{92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a}";
> +    const LIGHTNING_GUID = "{e2fda1a4-762b-4020-b5ad-a41df1933103}";
> +
> +    return Task.spawn(function*() {

ah cool! new generator function syntax here, looks cool. But why do we need it?

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Ah you are right, a bit overkill to use a Task here. I've switched to just using the callback function.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset e529163574ff