Closed
Bug 1133301
Opened 9 years ago
Closed 9 years ago
Fix in-tree consumers that use non-standard flag argument of String.prototype.replace in Add-on SDK
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
Derived from bug 1131107. Before fixing bug 1108382, we need to replace all of them with regexp literal or new RegExp(...).
|
Assignee | |
Comment 1•9 years ago
|
||
Assignee: nobody → arai.unmht
Attachment #8564693 -
Flags: review?(dtownsend)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Green on try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6249e23b4657 (reordered patches after the try run)
|
||
Updated•9 years ago
|
Summary: Fix in-tree consumers that uses non-standard flag argument of String.prototype.replace in addon-sdk. → Fix in-tree consumers that use non-standard flag argument of String.prototype.replace in Add-on SDK
|
||
Comment 3•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/051cbd20513e7fdd155ef05c140ff54c31f7ac3c Bug 1133301 - Do not use non-standard flag argument of String.prototype.replace in addon-sdk/. https://github.com/mozilla/addon-sdk/commit/91eb22f8675d760ec4c3913d6c9907200cc82b94 Merge pull request #1863 from arai-a/bug1133301 Bug 1133301 - Do not use non-standard flag argument of String.prototype.replace in addon-sdk/. r=Mossop
|
||
Updated•9 years ago
|
Attachment #8564693 -
Flags: review?(dtownsend) → review+
|
||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•