1133600 - Drop monitor before shutting down AudioStream

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

Spun off from bug 1108793.

AudioSink::Cleanup asserts that the monitor is held while doing a bunch of shutdown stuff, including shutting down the AudioStream.  If the code is rearranged, it shouldn't be necessary to hold the monitor for the AudioStream shutdown.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: patch v0

Comment 2

[Matthew Gregan [:kinetik]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6ab892aa6f1

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8565198 [details] [diff] [review]
patch v0

Review of attachment 8565198 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 4

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ab7017697a2b

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ab7017697a2b