Closed
Bug 1133625
Opened 9 years ago
Closed 9 years ago
Prepare Append Algorithm should return QuotaExceededError when exceeding buffer size
Categories
(Core :: Audio/Video, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: jya, Assigned: jya)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
1.22 KB,
patch
|
cajbir
:
review+
lmandel
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
4.33 KB,
patch
|
cajbir
:
review+
lmandel
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
1.64 KB,
patch
|
cajbir
:
review+
lmandel
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
As per spec: http://w3c.github.io/media-source/#sourcebuffer-prepare-append "If the buffer full flag equals true, then throw a QuotaExceededError exception and abort these step." If after evicting data the size of our TrackBuffer still exceeds the threshold size, we should return a QuotaExceededError error.
Assignee | ||
Comment 1•9 years ago
|
||
This mochitest triggered a quota exceeded error. Turned out, it was appending 190306 bytes in a loop, which on my machine would reach 75MB before loadedmetadata got fired.
Attachment #8565251 -
Flags: review?(cajbir.bugzilla)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f795ff4474ab
Assignee | ||
Comment 3•9 years ago
|
||
Implement step 6 of the Prepare Append Algorithm, if our buffer is full, throw a quota exceeded error
Attachment #8565256 -
Flags: review?(cajbir.bugzilla)
Updated•9 years ago
|
Priority: -- → P2
Updated•9 years ago
|
Attachment #8565251 -
Flags: review?(cajbir.bugzilla) → review+
Updated•9 years ago
|
Attachment #8565256 -
Flags: review?(cajbir.bugzilla) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Shouldn't allow an append greater than our threshold. However, YouTube attempts to load data in excess of 8MB when close to the end of the video, and never attempts to re-append should it error. As such, the sourcebuffer threshold can't be set to lower than 8MB with this change.
Attachment #8566208 -
Flags: review?(cajbir.bugzilla)
Updated•9 years ago
|
Attachment #8566208 -
Flags: review?(cajbir.bugzilla) → review+
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/661dcf41cef9 https://hg.mozilla.org/mozilla-central/rev/af39fc4994cc https://hg.mozilla.org/mozilla-central/rev/74014ad8e1f8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment 6•9 years ago
|
||
Pushed to 37 aurora as well with pre-approval from lmandel. https://hg.mozilla.org/releases/mozilla-aurora/rev/050e1d7b5246 https://hg.mozilla.org/releases/mozilla-aurora/rev/77ec05774a77 https://hg.mozilla.org/releases/mozilla-aurora/rev/419b32569a76
status-firefox37:
--- → fixed
Comment 7•9 years ago
|
||
Comment on attachment 8565256 [details] [diff] [review] Return an error when attempting to append too much data Requestion retroactive 37 uplift approval for all patches on this bug. Approval Request Comment [Feature/regressing bug #]: MSE [User impact if declined]: Spec compliance, less consistent testing. [Describe test coverage new/current, TreeHerder]: Landed on m-c. Mochitests. [Risks and why]: MSE-specific, so low. [String/UUID change made/needed]: None.
Attachment #8565256 -
Flags: approval-mozilla-aurora?
Comment 8•9 years ago
|
||
Comment on attachment 8565256 [details] [diff] [review] Return an error when attempting to append too much data As stated, this bug was pre-approved to land with a set of changes for MSE. Marking the approval after the fact.
Attachment #8565256 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•9 years ago
|
Attachment #8565251 -
Flags: approval-mozilla-aurora+
Updated•9 years ago
|
Attachment #8566208 -
Flags: approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•