Closed Bug 1133748 Opened 9 years ago Closed 9 years ago

Fix ipdl code for bridged protocols that are also opened

Categories

(Core :: IPC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: peterv, Assigned: peterv)

References

Details

Attachments

(1 file)

Currently we generate two identical Alloc* functions in the same actor.
Attached patch v1Splinter Review
Attachment #8565437 - Flags: review?(wmccloskey)
Comment on attachment 8565437 [details] [diff] [review]
v1

Review of attachment 8565437 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/ipdl/test/cxx/TestBridgeMain.h
@@ +77,5 @@
> +                                 ProcessId otherProcess) MOZ_OVERRIDE
> +    {
> +        // This shouldn't be called. It's just a byproduct of testing that
> +        // the right code is generated for a bridged protocol that's also
> +        // opened, but we only test briding here.

briding -> bridging
Attachment #8565437 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/4ef647d61d1f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: