Closed Bug 1133782 Opened 9 years ago Closed 6 years ago

Investigate why testPreferencesButton in browser_gmpProvider.js requires the manager window to be closed and reopened

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INACTIVE

People

(Reporter: spohl, Unassigned)

References

Details

Bug 1089867 uncovered that we had to close and reopen the manager window in the testPreferencesButton in browser_gmpProvider.js. The minimum for testPreferencesButton to pass is to close and reopen the manager window the first four times that the inner for loop is executed, i.e. the four times that we set the enabled pref to false (twice for OpenH264, twice for Adobe EME). Anything less than that will make us fail with either 1 or 2 failures. 

Closing and reopening the manager window seems wrong because:
* we lose a little bit of test-coverage and
* we may have uncovered an underlying issue here

We should figure out if we're dealing with some stale AddonManger UI state here, and fix accordingly.
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.