113404 - unnecessary big memcpy in nsZipArchive::InflateItem

Status: VERIFIED DUPLICATE of bug 189528

(Core :: General, defect)

Description

[Daniel Veditz [:dveditz]]

nsZipArchive::InflateItem does an extra memcpy of every file's content when it's
inflating into a buffer instead of a file (the usual case). It could use the
allocated buffer directly in the inflate step.

Comment 1

[Suresh Duddi (gone)]

It would be good to measure the improvement if this is a lot of time sink. Gut
feel is this could save about 215 memcpy of <filesize> and all files we read on
startup arent that big (< 4k). Let me know if you want me to help measure the cost.

If it is an easy thing to fix, go ahead.

Comment 2

[Alfred Kayser]

This 'bug' has been solved not so long ago, and should be closed.
See bug 189528.

*** This bug has been marked as a duplicate of 189528 ***

Comment 3

[Alec Flett]

yup.