1134061 - [META] IOS-139 Support Lightweight Themes

Status: RESOLVED WONTFIX

(Firefox for iOS :: Theme & Visual Design, defect, P5)

Description

[Jenn Chaulk (:jchaulk)]

Ability to apply a lightweight theme. Another card will be created to describe how a user would access themes initially (ie no dependency on AMO-hosted content for initial release)

Comment 1

[Darrin Henein [:darrin]]

This bug should cover the ability to display the theme image in every area defined in the mockups (behind the tab tray, behind the URL bar curve, etc).

Comment 2

[Wesley Johnston (:wesj)]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/641

This is a start at this. We have to show... a lot of background images here because some of them are in front and some are behind the browser. Alternatively, we could maybe put a single image behind the urlbar/statusbar?

I can try and split it up a bit more, but starting reviews/feedback.

Comment 3

[Stephan Leroux [:sleroux]]

Comment on attachment 8626389 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/641

Added a bunch of comments for nits that you can probably ignore but also left some about some architecture things we can change.

Comment 4

[Wesley Johnston (:wesj)]

Comment on attachment 8626389 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/641

Updated. Created a ThemeImageView: UIImageView class that you can basically use wherever you want a theme image. It will automatically update itself when the theme image changes. I left the Weak-list of images in to manage that which means LightweightThemeManager still knows something about views, but it isn't setting constraints on them anymore. I think that's what you wanted (I like this better).

Comment 5

[Brian Nicholson (:bnicholson)]

Comment on attachment 8626389 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/641

It's old, but I think this review was supposed to be directed toward sleroux :)

Comment 6

[Stephan Leroux [:sleroux]]

Comment on attachment 8626389 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/641

Looks like this patch is pretty bit-rotten. I tried to rebase from RC master but a lot of things went awry. Going to - this and we can come back and pick off the commits and pieces of work for it to work on latest RC.