1134494 - Change url_bar_entry_pressed outline color to action orange

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Per the new color palette, assuming the name does not change.

i.e. this icon [1]. Unknown if this also affects tablet.

NI :antlam for new assets.

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/drawable-xhdpi/url_bar_entry_pressed.9.png

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: urlbar_active_9patch_update.zip

Updated orange to #FF9500

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: urlbar_active.tar.gz

Compressed assets.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Your task: replace the assets in mobile/android/base/resources/drawable-*dpi/url_bar_entry_pressed.9.png with the resources in the attached tar ball. Then, make sure the url bar, when pressed, looks the same before and after the patch is applied with the exception that the color of the url bar will change to a slightly different orange hue.

To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^

Comment 4

[Anirudh S [:anirudh24seven]]

Attachment: Change url_bar_entry_pressed outline color to action orange

Comment 5

[Anirudh S [:anirudh24seven]]

Attachment: Change url_bar_entry_pressed outline color to action orange

Comment 6

[Anirudh S [:anirudh24seven]]

I have replaced the following configurations:

- hdpi
- mdpi
- xhdpi
- xxhdpi


However, I think there are other configurations for the same file for which no assets have been provided:

- large-hdpi-v11
- large-mdpi-v11
- large-xhdpi-v11
- large-xhdpi-v11

The existing assets for these configurations seem different. Therefore, I think we need new assets for them too.

Comment 7

[Anirudh S [:anirudh24seven]]

Attachment: Before Screenshot

Screenshot of the Address Bar border on a Nexus 5 before this bug fix.

Comment 8

[Anirudh S [:anirudh24seven]]

Attachment: After Screenshot

Screenshot of the Address Bar border on a Nexus 5 after this bug fix.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Hey, Anirudh!

Sorry for the delay - I'll do my best to make sure it doesn't happen again. Nice digging on the tablet files. However, it looks like the tablet assets have already been updated (perhaps back when we did the new tablet refresh in bug 1014156?) so no worries there - I'll review your patch.

If you're curious how I checked, I opened up the resource locally and used the gcolor2 application to check the color of the border in the tablet asset.

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=17acc97b03f0

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I made a push to our try test servers (see above).

Once it goes green, feel free to add the checkin-needed keyword [1]. Let me know if you need help reading the results. Note that all patches that use "checkin-needed" must also have an associated green try run.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree

Comment 12

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8597020 [details] [diff] [review]
Change url_bar_entry_pressed outline color to action orange

Review of attachment 8597020 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/94ca3cad5caa

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/94ca3cad5caa

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/94ca3cad5caa