Closed
Bug 1134579
Opened 9 years ago
Closed 9 years ago
IRC commands broken in nightly from Feb 19th 2015
Categories
(Chat Core :: IRC, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.6
People
(Reporter: nhnt11, Assigned: aleth)
Details
Attachments
(1 file, 1 obsolete file)
1.17 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
STR:
1) Try to use any IRC command
OR
2) Try to tab complete a command in an IRC conversation
Nothing happens, and the error console shows:
> Timestamp: 2/19/15, 4:51:32 PM
> Error: NS_NOINTERFACE: Component does not have requested interface [imICommand.usageContext]
> Source File: resource://gre/components/imCommands.js
> Line: 175
Assignee | ||
Comment 1•9 years ago
|
||
Adding command.__proto__ = ClassInfo("imICommand", "Chat command"); to jsProtoHelper::registerCommands fixes this.
Assignee | ||
Comment 2•9 years ago
|
||
Updated•9 years ago
|
Attachment #8566563 -
Flags: review?(clokep) → review+
Comment 3•9 years ago
|
||
Comment on attachment 8566563 [details] [diff] [review] commandinterface.diff Review of attachment 8566563 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for debugging this! :-) ::: chat/modules/jsProtoHelper.jsm @@ +817,5 @@ > if (!this.commands) > return; > > this.commands.forEach(function(command) { > + command.QueryInterface = XPCOMUtils.generateQI([Ci.imICommand]); This would override an existing implementation, which could be different if the object implemented more than one interface.
Attachment #8566563 -
Flags: review+ → review-
Assignee | ||
Comment 4•9 years ago
|
||
OK, but I didn't use hasOwnProperty as if it *is* already implemented, it's likely in the prototype chain.
Attachment #8566563 -
Attachment is obsolete: true
Attachment #8566637 -
Flags: review?(clokep)
Comment 5•9 years ago
|
||
Comment on attachment 8566637 [details] [diff] [review] commandinterface.diff v2 Review of attachment 8566637 [details] [diff] [review]: ----------------------------------------------------------------- Florian is curious how hard it would be to add a test...any idea?
Attachment #8566637 -
Flags: review?(clokep) → review+
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/fc563e49b1a2
Assignee | ||
Comment 7•9 years ago
|
||
(In reply to Patrick Cloke [:clokep] from comment #5) > Florian is curious how hard it would be to add a test...any idea? imCommands already has decent tests, the problem is that it didn't catch this as that test doesn't go through XPConnect. A test that could catch things like this would have to set up a conversation with some prpl and then check if it can find commands, without using loadSubScript. Maybe we can think of a good way to do something like this...
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in
before you can comment on or make changes to this bug.
Description
•