Closed
Bug 1134689
Opened 9 years ago
Closed 9 years ago
Conditionally compile the aurora update notification code
Categories
(Firefox for iOS :: Build & Test, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: st3fan, Assigned: st3fan)
Details
Attachments
(1 file)
Looks like we can use simple preprocessing inside swift code to conditionally include bits of code. We can use this to only include the update tester in the Aurora build.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8566619 -
Flags: review?(nalexander)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8566619 [details] [review] PR: https://github.com/mozilla/firefox-ios/pull/162 stefan and I discussed this in person. One request: fold the #if clauses into an AppConstants.swift file for future code inspection. It's stefan's choice if that happens now or in the near future.
Attachment #8566619 -
Flags: review?(nalexander) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Fixed with https://github.com/mozilla/firefox-ios/pull/162 Reviewed in person with :nalexander during work week.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•