1134831 - Add ability to localize "License information" string in addons manager

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Stephen A Pohl [:spohl]]

Since we're uplifting Adobe EME to FF 37 we should get all strings in as soon as possible.

Comment 1

[Stephen A Pohl [:spohl]]

Attachment: Patch

Comment 2

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8566776 [details] [diff] [review]
Patch

Review of attachment 8566776 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/extensions/internal/GMPProvider.jsm
@@ +62,5 @@
>    {
>      id:              "gmp-eme-adobe",
>      name:            "eme-adobe_name",
>      description:     "eme-adobe_description",
> +    licenseURL:      "",

Let's just make this null...

@@ +555,5 @@
>          let plugin = {
>            id: aPlugin.id,
>            name: pluginsBundle.GetStringFromName(aPlugin.name),
>            description: pluginsBundle.GetStringFromName(aPlugin.description),
> +          fullDescription: this.generateFullDescription(aPlugin, licenseInfo);

... and only add fullDescription if not null (or make it "" if required).

Comment 3

[Stephen A Pohl [:spohl]]

Attachment: Patch

Thanks, Georg! Addressed feedback. Carrying over r+.

Comment 4

[Stephen A Pohl [:spohl]]

Comment on attachment 8566796 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: Adobe EME
[User impact if declined]: The text "License information" in the addons manager will not be localizable.
[Describe test coverage new/current, TreeHerder]: This is a fairly small and well-understood change and local testing shows that everything is still working as expected.
[Risks and why]: None that I can think of.
[String/UUID change made/needed]: This adds the string "License information" to the list of strings that can be localized.

Comment 5

[Stephen A Pohl [:spohl]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dbfe4013530a

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8566796 [details] [diff] [review]
Patch

EME work is English only in 37. No need to uplift this one. Aurora-

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dbfe4013530a