1135007 - "Sync Now" button is not translated

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[xshen]

Attachment: screenshot1

Steps:
1)Install Fennec V36.0 for zh-CN(ftp://ftp.mozilla.org/pub/mobile/candidates/36.0-candidates/build1/android/zh-CN/) and choose language in the device settings as "Simplified Chinese".

2)Launch Fennec and setup Sync account successfully. 

3)Go to System Settings -> Account -> Firefox Account -> Click on your Sync account, then uncheck Sync. (see screenshot1.)

4)Launch Fennec and go to settings->Sync, there is an error message. Observe the “Sync now" button. It's in zh-CN. Back to settings then go to Sync again, "Sync now" button is displayed in English. 

Device:
Samsung S4

Comment 1

[YF (Yang)]

No "Sync Now" strings is not localized in zh-CN locale.
http://transvision.mozfr.org/?recherche=Sync+Now&repo=release&sourcelocale=en-US&locale=zh-CN&search_type=strings&perfect_match=perfect_match


Perhaps is the http://hg.mozilla.org/mozilla-central/annotate/5f1009731a97/mobile/android/base/resources/xml/fxaccount_status_prefscreen.xml#l63

Comment 2

[Nick Alexander :nalexander [he/him]]

Oops.  We have the entity at [1] and the string at [2], we're just not using it in the prefs XML.  (We are using it later, in code.)  Perfect first bug!

[1] https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/locales/en-US/sync_strings.dtd#201

[2] https://dxr.mozilla.org/mozilla-central/source/mobile/android/services/strings.xml.in#190

Comment 3

[YF (Yang)]

Attachment: Github Pull Request

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8567764 [details] [review]
Github Pull Request

Looks good.  I'll land this and request uplift.

Comment 5

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/06c2717a9cc5

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8567764 [details] [review]
Github Pull Request

Approval Request Comment
[Feature/regressing bug #]: Bug 966103.
[User impact if declined]: untranslated string.
[Describe test coverage new/current, TreeHerder]: it builds.
[Risks and why]: almost none.
[String/UUID change made/needed]: None, the string already existed.

Comment 7

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8567764 [details] [review]
Github Pull Request

Approval Request Comment
[Feature/regressing bug #]: Bug 966103.
[User impact if declined]: untranslated string.
[Describe test coverage new/current, TreeHerder]: it builds.
[Risks and why]: almost none.
[String/UUID change made/needed]: None, the string already existed.

Comment 8

[Nick Alexander :nalexander [he/him]]

Release managers: this is trivial.  It would be nice to get it all the way up to 36 (well, 37, I guess); do as you will.

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

36 is just about to ship so we missed the boat. We can possibly take this as a ride along in a point release if one is required.

Comment 10

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8567764 [details] [review]
Github Pull Request

This is certainly trivial. Let's get this into 37 Beta 1. I've cleared the Aurora approval as Aurora is now 38.

Beta+

Comment 11

[Ryan VanderMeulen [:RyanVM]]

This missed the uplift, so it's going to have to land on Aurora as well.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/192f6746dc45

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/06c2717a9cc5

Comment 14

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8567764 [details] [review]
Github Pull Request

Aurora+ to land in 38.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/108b0d3dc2fe