1135126 - Only show one Login doorhanger at a time

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

Attachment: Screenshot: Doorhangers showing for multiple accounts

The password doorhangers should be cleared upon adding new doorhangers, otherwise we may run into the case where there are doorhangers visible for irrelevant accounts.

Comment 1

[Chenxia Liu [:liuche]]

Don't show update/save login doorhangers at the same time. Showing a new login doorhanger should remove any previous login doorhangers.

Comment 2

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: bz://1135126/liuche

/r/6753 - Bug 1135126 - Only show one Login doorhanger at a time. r=ally

Pull down this commit:

hg pull -r fe05c077c281578373504be753c81c686236e80d https://reviewboard-hg.mozilla.org/gecko/

Comment 3

[Allison Naaktgeboren :ally]

Comment on attachment 8590015 [details]
MozReview Request: bz://1135126/liuche

https://reviewboard.mozilla.org/r/6751/#review5831

Ship It!

Comment 4

[Chenxia Liu [:liuche]]

https://hg.mozilla.org/integration/fx-team/rev/7807b2f2c9e6

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7807b2f2c9e6

Comment 6

[Teodora Vermesan (:TeoVermesan)]

Scenario:
1. Go to gmail.com 
2. log in with username:a and password: b => remember login for username "a"
3. log in with username:a and password: c => dismiss "update password" doorhanger
4. log in with username:d and password: e => only the remember login for username "d" is displayed

Verified as fixed using:
Device: Nexus 5 (Android 5.0)
Build: Firefox for Android 40.0a1 (2015-04-22)

Comment 8

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: Bug 1135126 - Only show one Login doorhanger at a time. r=ally