1135145 - Search field should be larger at tablet width so text is not truncated

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P4)

Description

[Christopher Van Wiemeersch [:cvan]]

1. Load a Marketplace page at tablet width (< 700px).
2. Notice the search placeholder text reads "Search the Market…" - the search box should be larger enough to accommodate the rest of the text (there's sufficient room).

https://marketplace.firefox.com/app/zirma
https://www.dropbox.com/s/r9i614h91hxn819/Screenshot%202015-02-20%2010.09.04.png?dl=0

Comment 1

[Atique Ahmed Ziad [:atiqueahmedziad]]

I want to fix it :) 
need help

Comment 2

[Andy McKay]

You've got the front end of the Marketplace setup, since you've already sent in a pull request on fireplace? So is your question about how to fix it? If so, it looks like the width is set to 230px in the CSS:

https://github.com/mozilla/fireplace/blob/650705daa7a2eb7c74ff4b065b81b6228ed04152/src/media/css/header.styl#L94-L104

This should be reproducible in the firefox developer tools, using responsive design view:

https://developer.mozilla.org/en/docs/Tools/Responsive_Design_View

Comment 3

[Atique Ahmed Ziad [:atiqueahmedziad]]

Attachment: pull request

Please review

Comment 4

[Andy McKay]

https://github.com/mozilla/fireplace/pull/1092

Thanks Atique for that fix!