1135368 - shell/futex.js should be disabled on non-nightly.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tooru Fujisawa [:arai]]

futex.js tests SharedArrayBuffer, which is enabled only on nightly.
I guess the existence checking code is wrong.

> if ((this.SharedArrayBuffer && this.AtomicsObject && this.getSharedArrayBuffer && this.setSharedArrayBuffer))
>     quit(0);

Comment 1

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Test permafail after Monday's Aurora uplift.

Comment 2

[Tooru Fujisawa [:arai]]

SharedArrayBuffer is defined only on nightly.
getSharedArrayBuffer and setSharedArrayBuffer are always defined.
AtomicsObject is never defined.
So the condition is always false, and it never quits.

Removing the check for AtomicsObject, and inverting the entire condition will solve this.
(not sure it's required to check the existence of getSharedArrayBuffer and setSharedArrayBuffer, since this is a shell-only test)

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Do not run shell/futex.js test if SharedArrayBuffer is not defined.

Fixed as comment #2.

Green on try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=42da6e931c3b&exclusion_state=all

Comment 4

[Tooru Fujisawa [:arai]]

Thank you!

https://hg.mozilla.org/integration/mozilla-inbound/rev/f9bce66211f2

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f9bce66211f2

Comment 6

[Lars T Hansen [:lth]]

Thanks for fixing this!