Closed
Bug 1135406
Opened 9 years ago
Closed 9 years ago
Remove unused browser.history preferences
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox38 fixed)
RESOLVED
FIXED
Firefox 38
Tracking | Status | |
---|---|---|
firefox38 | --- | fixed |
People
(Reporter: mfinkle, Unassigned)
Details
Attachments
(1 file)
1.13 KB,
patch
|
mcomella
:
review+
|
Details | Diff | Splinter Review |
We used these prefs back in XUL Fennec days. And the "browser.sessionhistory.max_entries" preference is actually a dupe from a different location in mobile.js
Attachment #8567548 -
Flags: review?(michael.l.comella)
Comment on attachment 8567548 [details] [diff] [review] prefs-cleanup v0.1 Review of attachment 8567548 [details] [diff] [review]: ----------------------------------------------------------------- r+ w/ nit. Don't forgot to add a commit description. Are you sure you don't want to remove this from Metro too? [1] :P [1]: https://mxr.mozilla.org/mozilla-central/search?string=browser.history.grouping&find=&findi=&filter=^%5B^\0%5D*%24&hitlimit=&tree=mozilla-central ::: mobile/android/app/mobile.js @@ -299,5 @@ > pref("browser.xul.error_pages.enabled", true); > > -pref("browser.history.grouping", "day"); > -pref("browser.history.showSessions", false); > -pref("browser.sessionhistory.max_entries", 50); This looks like it is still used: https://mxr.mozilla.org/mozilla-central/source/docshell/shistory/src/nsSHistory.cpp?rev=cfa520bee5fc#40 Are you sure you want to remove it?
Attachment #8567548 -
Flags: review?(michael.l.comella) → review+
Reporter | ||
Comment 2•9 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #1) > Are you sure you don't want to remove this from Metro too? [1] :P Metro stuff is being removed from the tree in a separate set of bugs. > > -pref("browser.sessionhistory.max_entries", 50); > > This looks like it is still used: > > https://mxr.mozilla.org/mozilla-central/source/docshell/shistory/src/ > nsSHistory.cpp?rev=cfa520bee5fc#40 > > Are you sure you want to remove it? This line was a dupe. We already have another "browser.sessionhistory.max_entries" line in mobile.js so we don't need two.
Reporter | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/18d513da3ce1
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/18d513da3ce1
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Assignee | ||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•