Closed Bug 1135590 Opened 9 years ago Closed 9 years ago

Disable dormant decoder shutdown on 37

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Version:
37 Branch
Platform:
x86
Windows 8
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox37 --- fixed

People

(Reporter: rillian, Assigned: rillian)

Details

Attachments

(1 file)

Disable dormant shutdown patch for 37
1.15 KB, patch
cpearce
: review+
lmandel
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
We're not confident with the current implementation. Better to disable this for the first beta.
Assignee: nobody → giles

        Attachment #8567819 -
        Flags: review?(cpearce)

    
    

    
  
Dormant code is windows only.
OS: Mac OS X → Windows 8

    
  

          status-firefox37:
          --- → affected

        Attachment #8567819 -
        Flags: review?(cpearce) → review+

    
    

    
  
We should re-enbale in 37 once Sotaro lands his fixes.

    
    

    
  
Landed on 37 aurora with pre-approval from lmandel.

https://hg.mozilla.org/releases/mozilla-aurora/rev/030fa1665346
Status: NEW → RESOLVED
Closed: 9 years ago

          status-firefox37:
          affected → fixed
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 8567819 [details] [diff] [review]
Disable dormant shutdown patch for 37

Requesting retroactive 37 uplift approval for tracking. This is the dormant pref flip I mentioned needing on Friday.

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Possible issues with YouTube interaction.
[Describe test coverage new/current, TreeHerder]: This turns off new code, reverting to earlier behaviour.
[Risks and why]: This will make us use more resources on background MSE tabs, which may contribute to oom crashes or playback failure, but we feel this is a safer config for the first beta.
[String/UUID change made/needed]: None.

        Attachment #8567819 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Comment on attachment 8567819 [details] [diff] [review]
Disable dormant shutdown patch for 37

As noted, pre-approval was granted for a collection of MSE changes. Adding approval to the bug.

        Attachment #8567819 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: