Closed Bug 1135726 Opened 9 years ago Closed 9 years ago

Add test manifests for Q1 Marionette test conversions

Categories

(Testing :: Firefox UI Tests, defect)

Product:
Testing
Component:
Firefox UI Tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox39 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla39
Tracking Flags:
Tracking Status
firefox39 --- fixed

People

(Reporter: galgeek, Assigned: galgeek)

Details

Attachments

(1 file)

github_pull_request.txt
52 bytes, text/x-github-pull-request
whimboo
: review+
whimboo
: review-
Details | Review 
Without appropriate manifest.ini files in place, new tests aren't added to test runs.
Assignee: nobody → galgeek
I've just updated the PR, with empty manifest.ini files in the folders where security tests are to be stored. This PR passes Travis.
Attachment #8568018 - Flags: review?(hskupin)
Attachment #8568018 - Flags: review?(hskupin) → review+
PR landed as:
https://github.com/mozilla/firefox-ui-tests/commit/459bbb10a1e3b1e26525918f027e74b03608dc0e
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
github does not create empty (0-length) files or directories that contain only empty (0 length) files.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8568018 [details] [review]
github_pull_request.txt

I've updated the PR.
Attachment #8568018 - Flags: review?(hskupin)
Comment on attachment 8568018 [details] [review]
github_pull_request.txt

We are not going with this workaround. It will solve itself when the first test landed for functional. Reviewers simply have to take care that the manifest files are also updated.
Attachment #8568018 - Flags: review?(hskupin) → review-
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Testing
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: