Closed Bug 113582 Opened 23 years ago Closed 23 years ago

put global xbl widgets on a diet

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla0.9.9

People

(Reporter: hewitt, Assigned: bugzilla)

Details

Attachments

(1 file, 1 obsolete file)

minor patch
1.67 KB, patch
Details | Diff | Splinter Review 
I need to scan through our global xbl bindings looking for stuff that can be
lazily executed or removed altogether.  I suspect we are doing a lot of work on
startup that can be postponed until they are needed.  Ideally, binding
constructors and fields should be doing very little work.
Attached patch patch (obsolete) — — Splinter Review 
patch - here's a start

I don't think there's much improvement to be made in this area, in general.
Please note that any mac-only optimizations were completely unintentional.  I 
added the !mac shortcircuit after making them.  If the reviewer would like, I 
can remove them.
Comment on attachment 60901 [details] [diff] [review]
patch

sr=hewitt
Attachment #60901 - Flags: superreview+
Attached patch minor patch — — Splinter Review 
since most dialogs don't specify buttons, it was pointless to do it as we had
been.
Attachment #60901 - Attachment is obsolete: true
Attachment #60901 - Flags: review+
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.9
last month's xul perf work included most of the xbl dieting that I intended to
do.  blake, since you have a couple patches here I'll give this to you and you
can close it as you please.
Assignee: hewitt → blaker
Status: ASSIGNED → NEW
nah. will fix other stuff as it comes up.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: