Closed Bug 1136199 Opened 9 years ago Closed 9 years ago

Do not add isDefaultBrowser to Telemetry Environment on Android.

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Product:
Firefox Health Report Graveyard
Component:
Client: Desktop
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox39 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 39
Tracking Flags:
Tracking Status
firefox39 --- fixed

People

(Reporter: Dexter, Assigned: Dexter)

References

Details

(Whiteboard: [ready])

Attachments

(1 file, 3 obsolete files)

bug1136199.patch - v4
4.26 KB, patch
Dexter
: review+
Details | Diff | Splinter Review 
Until bug 1134186 lands, just log an error if |_isDefaultBrowser| fails and don't log the exceptions.
Assignee: nobody → alessio.placitelli
Blocks: 1134269
Status: NEW → ASSIGNED
Summary: |TelemetryEnvironment._isDefaultBrowser| should not spamm test logs with exceptions. → |TelemetryEnvironment._isDefaultBrowser| should not spam test logs with exceptions.
Attached patch bug1136199.patch (obsolete) — — Splinter Review 

        Attachment #8568636 -
        Flags: review?(gfritzsche)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        bug1136199.patch - v2 (obsolete)
        — 
          — Splinter Review
      

    


  
We don't need to remove the exceptions from the logs after the first check.

        Attachment #8568636 -
        Attachment is obsolete: true

        Attachment #8568636 -
        Flags: review?(gfritzsche)

        Attachment #8568637 -
        Flags: review?(gfritzsche)

        Attachment #8568637 -
        Flags: review?(gfritzsche) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        bug1136199.patch - v3 (obsolete)
        — 
          — Splinter Review
      

    


  
To fix Android test failure, we drop isDefaultBrowser from the Environment if on Android.

        Attachment #8568637 -
        Attachment is obsolete: true

        Attachment #8568712 -
        Flags: review?(gfritzsche)

        Attachment #8568712 -
        Flags: review?(gfritzsche) → review+

    
    

    
  


  
Changed the commit message.

        Attachment #8568712 -
        Attachment is obsolete: true

        Attachment #8568742 -
        Flags: review+

    
  
Summary: |TelemetryEnvironment._isDefaultBrowser| should not spam test logs with exceptions. → Do not add isDefaultBrowser to Telemetry Environment on Android.
Whiteboard: [ready]

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/8a7c51d11500
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox39:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39

    
  
Product: Firefox Health Report → Firefox Health Report Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: