Closed
Bug 1136392
Opened 9 years ago
Closed 9 years ago
[Settings][Privacy Controls] The city name Dumont d'Urville is misspelled as DumontDUrville in the Custom Location city picker
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect, P2)
Tracking
(blocking-b2g:2.2+, b2g-v2.2 verified, b2g-master verified)
People
(Reporter: jmitchell, Assigned: marta)
References
Details
(Whiteboard: [3.0-Daily-Testing])
Attachments
(2 files)
Description: In Privacy Controls you can set a custom location in Location Accuracy. This feature will take you to a list (picker) of Region / City. Under the Antarctica the city of Dumont d'Urville has several formatting errors. DumontDUrville vs. Dumont d'Urville Repro Steps: 1) Update a Flame to 20150224010314 2) Launch Settings > Privacy Controls > Location Accuracy and set Location adjustment to custom location. 3) Set custom location to Antarctica / Dumont d'Urville Actual: DumontDUrville Expected: Dumont d'Urville Environmental Variables: Device: Flame Master (KK - Nightly - Full Flash - 319mem) Build ID: 20150224010314 Gaia: 31ac1cd7a029d5e46dd7c92537b5c973c5d9826e Gecko: 368c62292249 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 39.0a1 (Master) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0 Repro frequency: 100% See attached: screenshot
Reporter | ||
Comment 1•9 years ago
|
||
This issue also occurs in 2.2 (Privacy Controls not present prior to 2.2) Device: Flame 2.2 (KK - Nightly - Full Flash - 319mem) Build ID: 20150224002637 Gaia: 8e98fe665f3821d10d4d982cbb14cbe5b94d0be5 Gecko: 2b70d9d62799 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 37.0 (Master) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(pbylenga)
Comment 2•9 years ago
|
||
NI on component owner for nomination decision and assignment.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(pbylenga) → needinfo?(gchang)
Comment 3•9 years ago
|
||
Hi Marta, Can you help on this?
Blocks: Privacy_Control
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][COM=Privacy Panel]
Flags: needinfo?(gchang) → needinfo?(marta)
Comment 4•9 years ago
|
||
Proposed patch. Requesting review from pbylenga
Flags: needinfo?(marta)
Attachment #8570733 -
Flags: review?(pbylenga)
Updated•9 years ago
|
blocking-b2g: --- → 2.2+
Updated•9 years ago
|
Priority: -- → P2
Comment 6•9 years ago
|
||
Comment on attachment 8570733 [details] [review] [gaia] martasect:Bug_1136392 > mozilla-b2g:master Theo can you or a peer handle this review?
Attachment #8570733 -
Flags: review?(pbylenga) → review?(theo.chevalier11)
Updated•9 years ago
|
Assignee: nobody → marta
Comment 7•9 years ago
|
||
Comment on attachment 8570733 [details] [review] [gaia] martasect:Bug_1136392 > mozilla-b2g:master LGTM here as well, but again, Autolander won't land if I give it an r+, forwarding to Evelyn ;)
Attachment #8570733 -
Flags: review?(theo.chevalier11)
Attachment #8570733 -
Flags: review?(ehung)
Attachment #8570733 -
Flags: feedback+
Comment 8•9 years ago
|
||
Comment on attachment 8570733 [details] [review] [gaia] martasect:Bug_1136392 > mozilla-b2g:master City name updated in a json file should be fine.
Attachment #8570733 -
Flags: review?(ehung) → review+
Updated•9 years ago
|
Keywords: checkin-needed
Comment 10•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/d292d89970b83794e9dd7b3ea6edb8bea4ca6af0
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 11•9 years ago
|
||
Please request Gaia v2.2 approval on this patch when you get a chance.
Comment 13•9 years ago
|
||
Click the Details link on your attachment, set the "approval‑gaia‑v2.2" dropdown to '?', and fill out the questions in the textbox.
Flags: needinfo?(ryanvm)
Attachment #8570733 -
Flags: approval-gaia-v2.2?(dietrich)
Comment 14•9 years ago
|
||
(In reply to marta from comment #12) > how do I do it? HI Marta, I'll approve this patch as an exception although you've not filled in the approval request form, given I checked the patch myself and is a low risk risk change, but for next time around please do the fill the comments in so we understand the risk and testing done of the patch you are trying to land.
Updated•9 years ago
|
Attachment #8570733 -
Flags: approval-gaia-v2.2?(dietrich) → approval-gaia-v2.2+
Comment 15•9 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/7978800ed864886b23e3c0f1c138b6adde31734b
Comment 16•9 years ago
|
||
Verified @ Gaia-Rev a6b2d3f8478ec250beb49950fecbb8a16465ff6f Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/18619f8f6c5c Build-ID 20150315162500 Version 37.0 Device-Name flame FW-Release 4.4.2
Comment 17•9 years ago
|
||
This issue is verified fixed on the latest Nightly Flame 3.0 build. Actual Results: Dumont d'Urville is spelled correctly. Environmental Variables: Device: Flame 3.0 KK (Full Flash) (319 MB) BuildID: 20150317073344 Gaia: 738987bd80b0ddb4ccf853855388c2627e19dcc1 Gecko: 008b3f65a7e0 Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b Version: 39.0a1 (3.0) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+][COM=Privacy Panel] → [QAnalyst-Triage?][COM=Privacy Panel]
Flags: needinfo?(ktucker)
Updated•9 years ago
|
QA Whiteboard: [QAnalyst-Triage?][COM=Privacy Panel] → [QAnalyst-Triage+][COM=Privacy Panel]
Flags: needinfo?(ktucker)
You need to log in
before you can comment on or make changes to this bug.
Description
•