1136605 - [Stingray] expose isVisible and focus API for entry sheet

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::System, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

1. isVisible API: Determine whether this UI is visible or not, and return z-index.
2. focus API: Focus the default elementin this UI.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] sean2449:Bug_1136605 > mozilla-b2g:master

Comment 3

[Sung Chiu[:sungchiu]]

Comment on attachment 8574501 [details] [review]
[gaia] sean2449:Bug_1136605 > mozilla-b2g:master

1. Add isVisible, getElement and focus API in Captive_Portal (for EntrySheet). Notifications are handled in interactive_notification.
2. To test this patch:
   a. Under build/config/tv/custom-prefs.js, add user_pref('captivedetect.canonicalContent', 'no\n');

   b. To test EntrySheet, we have to change line 36 ‘if (FtuLauncher.isFtuRunning())’ to ‘if (true || FtuLauncher.isFtuRunning())’

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8574501 [details] [review]
[gaia] sean2449:Bug_1136605 > mozilla-b2g:master

Looks good.

Please find my comments at PR. We should include few lines of code to prevent multiple close function call.

Comment 5

[Sung Chiu[:sungchiu]]

Commit: https://github.com/mozilla-b2g/gaia/commit/2af946d09db6625e29cbc1c04bdd0b67c2acebef
Gaia-try(all green): https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=38e7312d616e