1136908 - [css-grid] Need test in property_database.js for nested repeat() syntax being rejected, for grid-template-rows & grid-template-columns

Status: RESOLVED DUPLICATE of bug 1118820

(Core :: CSS Parsing and Computation, enhancement)

Description

[Daniel Holbert [:dholbert]]

CSS Grid section 5.1.2 says:
  # The repeat() notation cannot be nested;
  # doing so makes the declaration invalid.

AFAICT, we don't have any automated tests for this (though local testing indicates that we do correctly reject it, if I'm testing it right).

We should add such a test.

I think a sample invalid value would be:
  grid-template-columns: repeat(1, repeat(1, 20px));
(whereas "grid-template-columns: repeat(1, 20px);" is valid)

Comment 1

[Daniel Holbert [:dholbert]]

Spec link: http://dev.w3.org/csswg/css-grid/#funcdef-repeat

Comment 2

[Kartik Gautam]

Hi,

can i take this bug ?

Thanks,
Kartik Gautam

Comment 3

[Daniel Holbert [:dholbert]]

Hi Kartik - thanks for volunteering!

But as it turns out, this bug has already been addressed, via changes in some other bug (specifically bug 1118820), and we didn't notice until now that this could be closed.

The relevant automated test file already includes the changes that I'd filed this bug about incorporating -- it already includes nested repeat() syntax, like this line:

    "repeat(1, repeat(1, 20px))",

https://searchfox.org/mozilla-central/rev/66547980e8e8ca583473c74f207cae5bac1ed541/layout/style/test/property_database.js#12197

Looks like that was added in https://hg.mozilla.org/mozilla-central/rev/1f0876a7e83d for Bug 1118820.

So, I'm closing this as a duplicate of Bug 1118820.