113691 - Composer freezes when removing multiple ol or ul tags.

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[TucsonTester1]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.6+)
Gecko/20011203 Netscape6/6.1b1
BuildID:    2001120303

When using the toolbar to remove multiple indented bulleted or number lines,
Composer freezes.

Reproducible: Always
Steps to Reproduce:
1. Launch Composer
2. Enter 10 letters of text
3. Click on the bullet or or numbered list button on the toolbar
4. Click on indent twenty-five times.
5. Click on the bullet or number list button on the toolbar (the same one you
clicked in step 3).

Actual Results:  Composer will freeze.  An end task will need to be done to
break out of it.

Expected Results:  Composer should not freeze when removing the tags.

I've had it freeze with as few as twenty indents.  With between 15 and 20
indents, it will hang for a bit, but recover.  This was reproduced on two other
machines, one using 98 (not SE), and the other using 95 OSR2.

Comment 1

[eberry]

Confirmed with 2001-12-05-04 under W2K

Comment 2

[Syd Logan]

I consulted with joe on this one, definitely this needs looking at. I can
reproduce on Windows NT, suspect it is cross platform (damn that Microsoft, I
can't use XP now cause they stole the term from us). I also observed that around
15 characters, I go *totally* glacial when hitting the OL button (or the UL
button) to undo the list. And I lock up at twenty. We must be iterating past
some boundary or something, I'm trying hard to think of an algorithm that would
slow down so exponentially like this one is.

Comment 3

[Joe Francis]

Recur                     sion?
     Recur            sion
          Recur   sion
               ...
                .
                .

Comment 4

[TucsonTester1]

This problem as mentioned in Comment 2 is also occuring on Mac OS X build
2001121004 using the steps specified by the reporter.

Comment 5

[TucsonTester1]

changing platform/OS to all as mentioned in comment 4

Comment 6

[Joe Francis]

pushing off 098 to 099

Comment 7

[Joe Francis]

Already spent half a day on this.  It's fairly complex - the post processing
code is the culprit, and I suspect the editor's concept of the range of the
document that has changed.  Estimating 2 days

Comment 8

[Syd Logan]

lists and hangs, oh my! plussing

Comment 9

[Joe Francis]

attaching patch for this.  patch also includes bug 120000 patch.  I'd like to
land them together anyway.

Comment 10

[Joe Francis]

Attachment: diffs to editor/libeditor

Comment 11

[kinmoz]

Comment on attachment 67606 [details] [diff] [review]
diffs to editor/libeditor

sr=[e-mail]

With the changes we disucssed.

Comment 12

[Joe Francis]

fix landed on trunk

Comment 13

[michael wendell]

Verified fixed on trunk build 02-08.