Closed Bug 1137756 Opened 9 years ago Closed 9 years ago

Make installers fails in mozharness desktop repacks

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox39 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla39
Tracking Flags:
Tracking Status
firefox39 --- fixed

People

(Reporter: massimo, Assigned: massimo)

References

Details

Attachments

(1 file)

Bug 1137756 - Use absolute paths in complete-patch.patch
2.44 KB, patch
gps
: review+
Details | Diff | Splinter Review 
make installer calls from l10n desktop repacks script, fail with this error:

07:17:34     INFO -  2015-02-20 10:17:34 (6.51 MB/s) - '/builds/slave/Linux-ash-l10n-1_3-00000000000/build/ash/obj-l10n/dist/update//previous.mar' saved [53362137/53362137]
07:17:34     INFO -  ERROR: could not open file in mar_open()
07:17:34     INFO -  ..//builds/slave/Linux-ash-l10n-1_3-00000000000/build/ash/obj-l10n/dist/update//previous.mar: No such file or directory
07:17:34     INFO -  Couldn't run "/builds/slave/Linux-ash-l10n-1_3-00000000000/build/ash/obj-l10n/dist/host/bin/mar" -t at /builds/slave/Linux-ash-l10n-1_3-00000000000/build/ash/tools/update-packaging/unwrap_full_update.pl line 51.
07:17:34    ERROR -  make[2]: *** [automation-partial-patch] Error 255


It fails because it tries to concatenate a relative path with an absolute one, so it cannot find the previous.mar file (just downloaded).

This patch, created by mshal solves this issue (tested on ash)
Attachment #8570556 - Flags: review?(gps) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/376b134c1495
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: