1137882 - Loop sever logs confusing number of room participants for "join" operations

Status: RESOLVED FIXED

(Hello (Loop) :: Server, defect)

Description

[Adam Roach [:abr]]

Currently, when the Loop server logs a "POST /rooms/{token}" with an operation of "join", the value logged for "participants" is what the value was before the transaction, not what it was at the end of the transaction. For example, when the first person joins the room, the log message indicates a total participant count of "0".

So far, this has confused everyone I've spoken to who has looked at the logs; the expectation, I believe, is that a successful join should be logged along with the resulting participant count, not the count before the join.

Comment 1

[Rémy Hubscher (:natim)]

Ok so what I propose to do for that.

Is to log the current number of users in case of an error (room full) and log the number of users with the new participant in case the user could join.

Comment 2

[Rémy Hubscher (:natim)]

Attachment: Link to Github PR — #309.

Comment 3

[Alexis Metaireau (:alexis)]

https://github.com/mozilla-services/loop-server/commit/fad6a5eb99785bdd2eb77b567ea113bfee5ef2e6