113789 - -moz-border-colors doesn't recognize transparent

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Joe Hewitt (gone)]

To avoid creating a special box just so I can put an outside focus border on
buttons, I just want to put a transparent border on the outside of the border
list initially, and turn it to a color when focused.

When I put transparent in the -moz-border-colors list, it is completely ignored.

Comment 1

[David Hyatt]

I deliberately didn't support transparent yet.  Darn.  I didn't think you'd need
that.

Comment 2

[Joe Hewitt (gone)]

got this working

Comment 3

[Joe Hewitt (gone)]

fixed

Comment 4

[André Dahlqvist]

Not sure if this checkin is the cause, but I'm now getting these build failures:

acy -pedantic -Wno-long-long -pthread -pipe  -DNDEBUG -DTRIMMED -O2 
-I/usr/X11R6/include -DMOZILLA_CLIENT -include ../../../../config-defs.h
-Wp,-MD,.deps/nsCSSRendering.pp
/home/andre/devel/cvs/mozilla/layout/html/style/src/nsCSSRendering.cpp
/home/andre/devel/cvs/mozilla/layout/html/style/src/nsCSSRendering.cpp: In
function `static PRIntn nsCSSRendering::MakeSide(nsPoint *, nsIRenderingContext
&, int, const nsRect &, const nsRect &, int, int, float, int)':
/home/andre/devel/cvs/mozilla/layout/html/style/src/nsCSSRendering.cpp:252:
warning: `int outsideEdge' might be used uninitialized in this function
/home/andre/devel/cvs/mozilla/layout/html/style/src/nsCSSRendering.cpp:252:
warning: `int insideEdge' might be used uninitialized in this function
/home/andre/devel/cvs/mozilla/layout/html/style/src/nsCSSRendering.cpp:252:
warning: `int outsideTL' might be used uninitialized in this function
/home/andre/devel/cvs/mozilla/layout/html/style/src/nsCSSRendering.cpp:252:
warning: `int insideTL' might be used uninitialized in this function
/home/andre/devel/cvs/mozilla/layout/html/style/src/nsCSSRendering.cpp:252:
warning: `int outsideBR' might be used uninitialized in this function
/home/andre/devel/cvs/mozilla/layout/html/style/src/nsCSSRendering.cpp:253:
warning: `int insideBR' might be used uninitialized in this function
/home/andre/devel/cvs/mozilla/layout/html/style/src/nsCSSRendering.cpp: In
function `static void nsCSSRendering::PaintBorder(nsIPresContext *,
nsIRenderingContext &, nsIFrame *, const nsRect &, const nsRect &, const
nsStyleBorder &, nsIStyleContext *, int, nsRect * = 0, int = 0, int = 0)':
/home/andre/devel/cvs/mozilla/layout/html/style/src/nsCSSRendering.cpp:1601:
warning: unused variable `const struct nsStyleBackground * ourBG'
/home/andre/devel/cvs/mozilla/layout/html/style/src/nsCSSRendering.cpp: In
function `static void nsCSSRendering::DrawCompositeSide(nsIRenderingContext &,
int, nsBorderColors *, const nsRect &, const nsRect &, PRInt16 *, int, nsRect *)':
/home/andre/devel/cvs/mozilla/layout/html/style/src/nsCSSRendering.cpp:1833:
warning: unused variable `PRInt32 np'
/home/andre/devel/cvs/mozilla/layout/html/style/src/nsCSSRendering.cpp:1770:
warning: `int shrinkage' might be used uninitialized in this function
/home/andre/devel/cvs/mozilla/layout/html/style/src/nsCSSRendering.cpp:1770:
warning: `int startRadius' might be used uninitialized in this function
/home/andre/devel/cvs/mozilla/layout/html/style/src/nsCSSRendering.cpp:1770:
warning: `int endRadius' might be used uninitialized in this function
/home/andre/devel/cvs/mozilla/layout/html/style/src/nsCSSRendering.cpp: In
function `static void nsCSSRendering::PaintBackground(nsIPresContext *,
nsIRenderingContext &, nsIFrame *, const nsRect &, const nsRect &, const
nsStyleBackground &, const nsStyleBorder &, int, int)':
/home/andre/devel/cvs/mozilla/layout/html/style/src/nsCSSRendering.cpp:2417: no
matching function for call to `nsIPresContext::GetBackgroundDraw (PRBool &)'
/home/andre/devel/cvs/mozilla/layout/html/style/src/nsCSSRendering.cpp:2416:
warning: `PRBool canDrawBackground' might be used uninitialized in this function
../../../../dist/include/string/nsBufferHandle.h: At top level:
/home/andre/devel/cvs/mozilla/layout/html/style/src/nsCSSRendering.cpp:83:
warning: `PRBool GetBGColorForHTMLElement(nsIPresContext *, const nsStyleColor
*&)' declared `static' but never defined
make[6]: *** [nsCSSRendering.o] Error 1
make[6]: Leaving directory
`/home/andre/devel/cvs/mozilla/obj-i686-pc-linux-gnu/layout/html/style/src'
make[5]: *** [libs] Error 2
make[5]: Leaving directory
`/home/andre/devel/cvs/mozilla/obj-i686-pc-linux-gnu/layout/html/style'
make[4]: *** [libs] Error 2
make[4]: Leaving directory
`/home/andre/devel/cvs/mozilla/obj-i686-pc-linux-gnu/layout/html'
make[3]: *** [libs] Error 2
make[3]: Leaving directory
`/home/andre/devel/cvs/mozilla/obj-i686-pc-linux-gnu/layout'
make[2]: *** [tier_9] Error 2
make[2]: Leaving directory `/home/andre/devel/cvs/mozilla/obj-i686-pc-linux-gnu'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/home/andre/devel/cvs/mozilla/obj-i686-pc-linux-gnu'
make: *** [build] Error 2