Closed Bug 1137939 Opened 9 years ago Closed 9 years ago

[RTL][Contacts] 'Set ICE Contacts' page does not align contact to the right for English letters

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect, P3)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(b2g-v2.2 affected, b2g-v2.5 verified, b2g-master verified)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
b2g-v2.2 --- affected
b2g-v2.5 --- verified
b2g-master --- verified

People

(Reporter: pcheng, Assigned: autra)

References

Details

(Whiteboard: [3.0-Daily-Testing],[2.2-nexus-5-l],[2.5-rtl-test-run])

Attachments

(5 files)

screenshot of issue on Flame 3.0
48.66 KB, image/png
Details
AreisKK_v2.5_Arabic.png
78.96 KB, image/png
Details
[gaia] Phoxygen:bug1137939-rtl_ice_contacts > mozilla-b2g:master
46 bytes, text/x-github-pull-request
arcturus
: review+
mpotharaju
: approval-gaia-v2.5+
Details | Review
verified_Flame_v2.6.png
51.60 KB, image/png
Details
verified_Flame_v2.5.png
50.69 KB, image/png
Details 
Description:
The page to set ICE contacts does not align the contact's name to the right if the name is not in Arabic.

Prerequisites:
- In RTL language

STR:
1) Create a contact with phone number and name in Roman characters
2) Set step 1's contact as an ICE contact via Settings (gear icon)
3) Observe the page after setting up an ICE contact

Expected: Text is right aligned even if it's not in an RTL language

Actual: Text is left aligned when it's not in an RTL language. See screenshot.

Device: Flame 3.0 Master (full flash 319MB)
BuildID: 20150227010229
Gaia: 7512026a377271a0cade12d70846557f0bc7781c
Gecko: c7968255c1ea
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0
This issue also occurs on Flame 2.2.

Device: Flame 2.2
BuildID: 20150227002521
Gaia: eb6a5ac9081d3962198e0f4520b0743d716d7a27
Gecko: c8a38dcfbebc
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Blocks: contacts-rtl
QA Whiteboard: [QAnalyst-Triage?]
status-b2g-v2.2: --- → affected
status-b2g-master: --- → affected
Flags: needinfo?(ktucker)
Whiteboard: [3.0-Daily-Testing]
Priority: -- → P3
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage+] → [rtl-impact][QAnalyst-Triage+]
QA Whiteboard: [rtl-impact][QAnalyst-Triage+] → [rtl-impact][QAnalyst-Triage+][MGSEI-Triage+]
Whiteboard: [3.0-Daily-Testing] → [3.0-Daily-Testing],[2.2-nexus-5-l]
Attached image AreisKK_v2.5_Arabic.png — 
This issue can be reproduced on latest Areis KK v2.5 build by the same STR in comment 0.
Actual Result: Text is left aligned when it's not in an RTL language.
See attachment:AreisKK_v2.5_Arabic.png.
Reproducing rate:10/10
 
Device: Aries KK v2.5 build
Build ID               20150806003241
Gaia Revision          581de383687dc441a878d2c91a0167c6ec688fef
Gaia Date              2015-08-05 01:48:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9801f91760d9
Gecko Version          42.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150805.235801
Firmware Date          Wed Aug  5 23:58:08 UTC 2015
Bootloader             s1
This issue still can be reproduced on latest AriesKK&FlameKK v2.5 build.
FlameKK v2.5 (512mb)Build ID:20151101150206
AriesKK v2.5 Build ID:20151101012023
Whiteboard: [3.0-Daily-Testing],[2.2-nexus-5-l] → [3.0-Daily-Testing],[2.2-nexus-5-l],[2.5-rtl-test-run]
Assignee: nobody → augustin.trancart
Comment on attachment 8684312 [details] [review]
[gaia] Phoxygen:bug1137939-rtl_ice_contacts > mozilla-b2g:master

Hey Francisco, please R?
Attachment #8684312 - Flags: review?(francisco)
Btw, it seems that we have a regression on the arrows on the button, they don't appear any more. I'll try to bisect later :-)
Status: NEW → ASSIGNED
Comment on attachment 8684312 [details] [review]
[gaia] Phoxygen:bug1137939-rtl_ice_contacts > mozilla-b2g:master

LGTM
Attachment #8684312 - Flags: review?(francisco) → review+
Landed in master:

https://github.com/mozilla-b2g/gaia/commit/0f90702660d20024603350024b693e3585332eea

... and nga branch:

7af5768
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8684312 [details] [review]
[gaia] Phoxygen:bug1137939-rtl_ice_contacts > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: poor rtl experience
[Testing completed]: on flame master
[Risk to taking this patch] (and alternatives if risky): very low: only css alignment.
[String changes made]: none
Attachment #8684312 - Flags: approval-gaia-v2.5?
This bug has been verified as "pass" on the latest build of Flame KK 2.6 and Aires KK 2.6 by the STR in comment 0.

Actual results: The text is right aligned when it's not in an RTL language as expected.
See attachment: verified_Flame_v2.6.png
Reproduce rate: 0/10


Device: Aries KK 2.6 (master) user build (Pass)
Build ID               20151118145707
Gaia Revision          cba7e4b86361af31b153cfebaf99900e0b860f7b
Gaia Date              2015-11-18 09:45:49
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1d6155d7e6c91fa5ec1ef6927f3d3a044187896d
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151118.141704
Firmware Date          Wed Nov 18 14:17:11 UTC 2015
Bootloader             s1

Device: Flame KK v2.6 512mb (master) user build (Pass)
Build ID               20151118150206
Gaia Revision          cba7e4b86361af31b153cfebaf99900e0b860f7b
Gaia Date              2015-11-18 09:45:49
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1d6155d7e6c91fa5ec1ef6927f3d3a044187896d
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151118.184136
Firmware Date          Wed Nov 18 18:41:48 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0
Comment on attachment 8684312 [details] [review]
[gaia] Phoxygen:bug1137939-rtl_ice_contacts > mozilla-b2g:master

Approved for 2.5 uplift. RTL late landing. 

Thanks
Attachment #8684312 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
(In reply to Carsten Book [:Tomcat] from comment #14)
> for 2.5
> https://github.com/mozilla-b2g/gaia/commit/
> 198db07f0ff3d14a36ed6eda7e5343b036a82263

err wrong flag
status-b2g-v2.2: fixed → affected
status-b2g-v2.5: --- → fixed
This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: The text is right aligned when it's not in an RTL language.
See attachment: verified_Flame_v2.5.png
Reproduce rate: 0/10


Device: Aries KK v2.5 (Pass)
Build ID               20151125233358
Gaia Revision          93b8bf2de3258c25199d97036c50a87667059148
Gaia Date              2015-11-25 10:29:48
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/a883c12a75da3fa58b64bcb94923b013c71f546a
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151125.224212
Firmware Date          Wed Nov 25 22:42:20 UTC 2015
Bootloader             s1

Device: Flame 2.5 (512mb) (Pass)
Build ID               20151125234005
Gaia Revision          93b8bf2de3258c25199d97036c50a87667059148
Gaia Date              2015-11-25 10:29:48
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/a883c12a75da3fa58b64bcb94923b013c71f546a
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151125.224957
Firmware Date          Wed Nov 25 22:50:06 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0
Status: RESOLVED → VERIFIED
status-b2g-v2.5: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: