1138229 - Should GetOutputStreamInfo() be called after IMFTransform::SetOutputType()/MF_E_TRANSFORM_STREAM_CHANGE

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Karl Tomlinson (:karlt)]

Referring to MFT_OUTPUT_STREAM_PROVIDES_SAMPLES
"These flags remain constant unless the media type for the output stream changes."

https://msdn.microsoft.com/en-us/library/windows/desktop/ms704014%28v=vs.85%29.aspx

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: GetOutputStreamInfo() after each SetOutputType()

https://treeherder.mozilla.org/#/jobs?repo=try&revision=325489057c48

Comment 2

[Karl Tomlinson (:karlt)]

I wonder whether this may be related to some of the hangs in bug 1129455.
Perhaps there's a remote chance.

Comment 3

[Karl Tomlinson (:karlt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6bd19f34057f

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6bd19f34057f

Comment 5

[Karl Tomlinson (:karlt)]

Comment on attachment 8571088 [details] [diff] [review]
GetOutputStreamInfo() after each SetOutputType()

Approval Request Comment
[Feature/regressing bug #]: mp4 media
[User impact if declined]:
Uncertain.  Requesting approval based on the possibility that this might help with shutdown or video playback hangs tracked in bug 1129455.

[Describe test coverage new/current, TreeHerder]:
There are some web platform tests and mochitests, but I don't know whether or not any would or what exactly would trigger the scenario addressed here in handling responses from OS libraries.
[Risks and why]: simple patch, so low risk.
[String/UUID change made/needed]: none.

Comment 6

[Karl Tomlinson (:karlt)]

Comment on attachment 8571088 [details] [diff] [review]
GetOutputStreamInfo() after each SetOutputType()

Approval Request Comment

Adding request for beta to request in comment 5.
Bug 1129455 is a big enough issue and the risk here is low enough that this seems worth taking in the hope that it might help with Bug 1129455.

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

[Tracking Requested - why for this release]:

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3293b116b319

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/14cc1f92c84c