Closed Bug 113831 Opened 23 years ago Closed 23 years ago

Tooltip preference does not take effect until Mozilla restart

Categories

(Core :: XUL, defect, P3)

Product:
Core
Component:
XUL
Platform:
x86
Windows ME
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.9

People

(Reporter: lkolesza, Assigned: samir_bugzilla)

References

Details

Attachments

(2 files)

Remove attempt to cast data to self since we |RegisterCallback()| with |nsnull|, not |(void*) this|.
917 bytes, patch
Details | Diff | Splinter Review
Same patch as above but diff -w for reviewers' benefit.
771 bytes, patch
morse
: review+
hewitt
: superreview+
Details | Diff | Splinter Review 
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:0.9.6+) Gecko/20011206
BuildID:    2001120603



Reproducible: Always
Steps to Reproduce:
1. Hover over back button to determine tooltip status
2. Go to Preferences dialog
2. Go to Appearance tab
3. Check or uncheck "Show Tooltips"
4. Press Ok to apply changes
5. Hover over back button

Actual Results:  Tooltip status did not change

Expected Results:  Tooltip status changes to that selected in Preferences dialog

In 0.9.6, I get a popup after hitting ok saying "Prefered languages changes will
take effect when you restart Mozilla", but the Tooltip change takes effect
immediately.  In 2001120603, I don't get any popup.
terri, d'you see this?
Summary: Tooltip preference does not take effect until Mozilla restart → Tooltip preference does not take effect until Mozilla restart
Yes, I do see this with Win ME build 2001120603, if you shut down moz and 
restart, the change in tooltip preferences does take effect
The pref is being set correctly.  

-> hewitt
Assignee: sgehani → hewitt
Component: Preferences → XP Toolkit/Widgets
QA Contact: sairuh → tpreston
*** Bug 116009 has been marked as a duplicate of this bug. ***
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.9
*** Bug 116989 has been marked as a duplicate of this bug. ***
morse, please r.
alecf, please sr.
Assignee: hewitt → sgehani
Status: ASSIGNED → NEW
Priority: -- → P3
Target Milestone: mozilla0.9.9 → mozilla0.9.8
Comment on attachment 62799 [details] [diff] [review]
Same patch as above but diff -w for reviewers' benefit.

r=morse
Attachment #62799 - Flags: review+
Keywords: patch, review
Comment on attachment 62799 [details] [diff] [review]
Same patch as above but diff -w for reviewers' benefit.

sr=hewitt
Attachment #62799 - Flags: superreview+
Status: NEW → ASSIGNED
Keywords: review
Whiteboard: [ready to checkin]
Target Milestone: mozilla0.9.8 → mozilla0.9.9
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: [ready to checkin]
Verified Fixed Win ME build 2002022808
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: