1138450 - Add version fields to built manifest.webapp files

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Staś Małolepszy :stas]

In bug 1118946 we added moz.b2g.version.  Let's use it to add a "version" field to Gaia manifest.webapp files.  This will come in handy for langpacks (bug 1118946).

Comment 1

[Staś Małolepszy :stas]

moz.b2g.version is in "x.y" format.  Is that good enough for manifest's "version" or should we use "x.y.z"?

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1138450-add-app-version-to-manifest > mozilla-b2g:master

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

So, what I'm going to give you here is:

{
  "version": "3.0"
}

or

{
  "version": "2.2"
}

Can you confirm that this is what you expect for your App name API to work?

Comment 4

[[:fabrice] Fabrice Desré]

yes, that's fine.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8572834 [details] [review]
[gaia] zbraniecki:1138450-add-app-version-to-manifest > mozilla-b2g:master

Ricky, would you have time to look at this? It's a small thing and would love to have it in time for the Gecko API Name patch.

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8572834 [details] [review]
[gaia] zbraniecki:1138450-add-app-version-to-manifest > mozilla-b2g:master

LGTM. r+

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/mozilla-b2g/gaia/commit/05e2843ebd74db3b4ef965be292b6040a4624824
Merge: https://github.com/mozilla-b2g/gaia/commit/febc780ed1ba8e52d5797f36316a952548eda053

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8572834 [details] [review]
[gaia] zbraniecki:1138450-add-app-version-to-manifest > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1118946
[User impact] if declined: firefox os localized with langpack will not have translated app names on the homescreen
[Testing completed]: local + gaia-try
[Risk to taking this patch] (and alternatives if risky): This patch only adds one field (app version) to app's manifest at buildtime.
[String changes made]: none

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch against 2.2

Ricky, can you just check that my 2.2 patch looks as it should? 

The post-manifest.js file in 2.2 looks different from master, so I'd prefer to get your rubber stamp before I push. Thanks :)

Comment 10

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8575097 [details] [diff] [review]
patch against 2.2

Review of attachment 8575097 [details] [diff] [review]:
-----------------------------------------------------------------

r+  again.

Comment 11

[Zibi Braniecki [:zbraniecki][:gandalf]]

2.2: https://github.com/mozilla-b2g/gaia/commit/7fdef6943189b175c2b474b1656ef27a13d646fe