1138527 - when font inflation is enabled, CSS ruby should not be inflated differently from the base text

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Jonathan Kew [:jfkthame]]

Currently, we apply font inflation calculations to ruby text independently of the calculation for the base text. This means we're liable to inflate the ruby annotation much more than the base, and thereby lose the expected size contrast and mess up the layout.

I think that for <rt>, we should inflate only as much as the inflation being applied to the base text, even though this will typically leave the ruby text smaller than the minimum size being applied to normal text in the same inflation container.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Reftest for application of font inflation to ruby

Here's a reftest that currently fails because we inflate the ruby text independently of its base text.

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

Attachment: patch

Comment 3

[Xidorn Quan [:xidorn] UTC+11]

Attachment: patch for reftest

Identical to jfkthame's patch, except the order in reftest.list and removal of "fails". Thanks for the great reftest, jfkthame.

Comment 4

[Xidorn Quan [:xidorn] UTC+11]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6afcb2625bce

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

https://hg.mozilla.org/integration/mozilla-inbound/rev/08e06ab7702a
https://hg.mozilla.org/integration/mozilla-inbound/rev/2330bb9f7da0

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Is it really necessary to modify that code, or should you instead be making sure that ruby annotation containers don't end up being a font inflation container?

Comment 7

[Xidorn Quan [:xidorn] UTC+11]

I don't think ruby annotation containers are ever font inflation container. [1] (Though some code there doesn't use a proper name.)

[1] https://dxr.mozilla.org/mozilla-central/source/layout/generic/nsFrame.cpp#441

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/08e06ab7702a
https://hg.mozilla.org/mozilla-central/rev/2330bb9f7da0