1138645 - Update remaining callsites to use newChannel2 in browser/metro

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1138645_browser_metro.patch

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Mark, in Bug 1038756 we started attaching a loadInfo to every channel whenever the channel gets created through NS_NewChannel in nsNetUtil.h. Now we are expanding the loadInfo attachment to also include channels that get created within JS to ultimately end up having a loadInfo on every channel.

Please find a description of all the required arguments to create a channel here [1] or alternatively here [2].

Please keep in mind that all the arguments that are passed to newChannel become security critical once we move security checks into AsyncOpen(). We are not experts within browser/metro code, hence I was wondering if you review that patch or delegate it to someone who knows that code really well. Thanks!

[1] http://mxr.mozilla.org/mozilla-central/source/netwerk/base/nsNetUtil.h#191
[2] http://mxr.mozilla.org/mozilla-central/source/netwerk/base/nsIIOService.idl#69

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8571542 [details] [diff] [review]
bug_1138645_browser_metro.patch

This patch looks pretty sane to me. Also, the browser/metro code is likely going to be removed very soon, so we should be able to free people from needing to keep the code updated, without a product to build/verify.

Comment 4

[Christoph Kerschbaumer [:ckerschb]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c3fa9af19578

Comment 5

[Ekanan Ketunuti]

https://hg.mozilla.org/mozilla-central/rev/c3fa9af19578