1138647 - Tab sharing should cope with tab-tearing

Status: RESOLVED INCOMPLETE

(Hello (Loop) :: Client, defect, P3)

Description

[Mark Banner (:standard8)]

When a user tears a tab, tab-sharing currently goes to the next tab in the current window.

I think it would make sense to follow the tab that is shared.

Comment 1

[:shell escalante]

Hi RT, Hi Sevaan,

Can you verify the desired tab sharing behavior when a tab is "tore" off the current shared tab session?

I don't think the current behavior would be a ship stopper for 38 - so put as P2 that we could adjust.  But can change based on your input.

Comment 2

[Sevaan Franks [:sevaan]]

If a user tears off the tab, sharing should follow it. This means that if the conversation window is in the bottom-right in Firefox, it should be brought over to the new torn-off tab.

When we apply clearer indication of sharing (e.g. the glow, badges) this should follow the torn-off tab too, which becomes the new shared window.

Comment 3

[Romain Testard [:RT]]

I agree with Sevaan there, seems to make more sense.

Comment 4

[Mike de Boer [:mikedeboer]]

(In reply to Romain Testard [:RT] from comment #3)
> I agree with Sevaan there, seems to make more sense.

OK, this will require some engineering work. What's the priority here?

Comment 5

[Romain Testard [:RT]]

I don't see this as a blocker for Fx38 or Fx39 since it's an edge case, does not create instability and there is a work-around. 
The work on context sharing is higher priority than this for Fx39.
Marking this as P3 since it seems to fit this definition better.

Comment 6

[Ian Bicking (:ianbicking)]

With the new experience and way we are treating tab sharing and windows, I think the current behavior is actually desired.  Sevaan?

Comment 7

[Sevaan Franks [:sevaan]]

I think for now, while the product is about sharing your tab, it would be best to follow the tab. In the future when it's about sharing multiple tabs, then it would make sense to remain with the current approach and stay with the window.

Why do you think the current behavior works best for the current case?

Comment 8

[Ian Bicking (:ianbicking)]

Right now implicitly we are binding Hello to one window.  I'm not even sure where or if we made a decision about that, maybe for now it's just fallen out of the implementation.  Because of this we implicitly have a scope of sharing that includes the window you are in and excludes other windows.  Though thinking through it, I could imagine how dragging the tab is a useful way to "fix" the session you are in – to isolate work, or even potentially the sharing session to a different window.

On the other side, laziness suggests we leave it as it is, as I don't believe that right now either behavior is easy to understand or make use of, so without a clear goal we should leave things as they are, and if we have a clear goal later we should articulate that in a new bug and with a clear purpose.

Comment 9

[Sevaan Franks [:sevaan]]

Sounds good to me. Another thing to test with users.

Comment 10

[Mark Banner (:standard8)]

Support for Hello/Loop has been discontinued.

https://support.mozilla.org/kb/hello-status

Hence closing the old bugs. Thank you for your support.