1138941 - We should display a better string when we've failed to obtain the camera and video devices

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Mark Banner (:standard8)]

Following bug 1106941 we will be displaying "Something went wrong" if there's a catastrophic error getting the camera or microphone.

We need to display something better in that case.

For the current link-clicker UI we display: "We could not get access to your microphone or camera. Please reload the page to try again."

However, this is slightly worse-case than that. I would suggest either just "We could not get access to your microphone or camera." or "We could not access any microphone or camera devices."

Note: this would be primarily for desktop, though it could show up on link-clicker is some rare circumstances as well.

Sevaan: any preference of strings here?

Comment 1

[Sevaan Franks [:sevaan]]

"We were unable to find any microphone or camera devices." Maybe?

Comment 2

[Matej Novak [:matej]]

I prefer not to use "we" because it brings up the question of who, exactly, "we" is.

I would suggest one of the following:

No camera or microphone found.

No camera or microphone detected.

(Is it possible that we might detect one but not the other?)

Comment 3

[Sevaan Franks [:sevaan]]

Thanks, I like "No Camera or Microphone found".

Standard8:

> (Is it possible that we might detect one but not the other?)

Comment 4

[Mark Banner (:standard8)]

(In reply to Sevaan Franks [:sevaan] from comment #3)
> > (Is it possible that we might detect one but not the other?)

I believe in the case I'm looking at, it would be hard to tell. We will in future be able to tell what's missing.

Comment 5

[Mark Banner (:standard8)]

Attachment: Display a better string when we've failed to obtain the camera and video devices for Loop.

Updates the appropriate views to display the requested string. This should give users a better change of understanding what's happening.

To test this, I changed the two "if (!sources.Length())" lines in GetUserMediaTask::SelectDevice to negate the statement (i.e. remove the exclamation mark).

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8585441 [details] [diff] [review]
Display a better string when we've failed to obtain the camera and video devices for Loop.

Review of attachment 8585441 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay! Looks good; one minor nit-pick included, free of charge.  :-)

r=dmose

::: browser/locales/en-US/chrome/browser/loop/loop.properties
@@ +253,5 @@
>  
>  cannot_start_call_session_not_ready=Can't start call, session is not ready.
>  network_disconnected=The network connection terminated abruptly.
>  connection_error_see_console_notification=Call failed; see console for details.
> +no_media_failure_message=No Camera or Microphone found

It looks a bit odd to capitalize "Camera" and "Microphone", but not "found".

Comment 7

[Sevaan Franks [:sevaan]]

Should be "No camera or microphone found" like what Matej suggested. I put in the capitals by mistake, sorry!

Comment 8

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/5c706289607d

For qe-verify: Test, if possible, on a machine without camera/microphone devices.

Check that a link generator for a room correctly gets a "No camera or microphone found" message.

Also, check that attempting a direct call results in the same message.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5c706289607d

Comment 10

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Will be verified together with bug 1106941.

Comment 11

[Ada [:adalucinet]]

Verified fixed on 40.0b4 (Build ID: 20150713153304), under Windows 7 64-bit and Ubuntu 14.04 32-bit - "No camera or microphone found" message is properly displayed, including when performing a FxA call.