1139308 - [Nexus 5][Settings]PIN code input page won't disppear in time.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Alissa（leave from Mozilla）]

Attachment: logcat1.txt

[1.Description]:
[Nexus 5][Settings] For the SIM card with a PIN code, when we input the code and tap OK button, this page won't disspear immediately.
Found at:10:41
See attachments:PINcodeinputpage.3gp,logcat1.txt

[2.Testing Steps]: 
1.Insert a SIM card with PIN code and reboot device.
2.Input PIN code and tap OK.

[3.Expected Result]: 
2.After tapping OK, device should go to home page immediately.

[4.Actual Result]: 
2.The PIN code page won't disppear immediately. When we tap ok button again, it will disppear immediately.

[5.Reproduction build]: 
N5:
Build ID               20150303002527
Gaia Revision          3d188c414e30acc392253d5389a42352fcfbc183
Gaia Date              2015-03-03 00:53:42
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c89aad487aa5
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.0
Firmware(Incremental)  eng.cltbld.20150303.040940
Firmware Date          Tue Mar  3 04:09:55 EST 2015
Bootloader             HHZ12d

Flame 2.2 build:
Build ID               20150303002527
Gaia Revision          3d188c414e30acc392253d5389a42352fcfbc183
Gaia Date              2015-03-03 00:53:42
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c89aad487aa5
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150303.034757
Firmware Date          Tue Mar  3 03:48:06 EST 2015
Bootloader             L1TC000118D0

Flame 3.0:
Build ID               20150303010233
Gaia Revision          c8ed1085a67490a1ecd7f275e5de9487e1b93b1d
Gaia Date              2015-03-02 20:14:21
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0b3c520002ad
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150303.044015
Firmware Date          Tue Mar  3 04:40:27 EST 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Occasionally Recurrence,5/5

[7.TCID]: 
Free Test

[8.Note]:
This issue does not exist on Flame 2.2.

Comment 1

[Alissa（leave from Mozilla）]

Attachment: PINcodeinputpage.3gp

Comment 2

[howie [:howie]]

qawanted to check on nexus 5 v3.0

Comment 3

[Shine(Leave from Mozilla)]

Attachment: N5v3.0 Video

The phenomenon on N5 v3.0 is a little different from N5 v2.2：
N5 v2.2: After you input PIN code and tap “OK” button, the keyboard can't be hiddend, and the PIN code page will display about 2~3 second and then disappear.

N5 v3.0: After you input PIN code and tap “OK” button, the keyboard will be hidden, and the PIN code page will display about 1 second and then disappear.
See attachment: N5_3.0_Video.MP4 & logcat_1453.txt
Rate: 5/5
N5 v3.0 build:
Build ID               20150308160204
Gaia Revision          fea83511df9ccba64259346bc02ebf2c417a12c2
Gaia Date              2015-03-08 06:36:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/eab4a81e4457
Gecko Version          39.0a1
Device Name            hammerhead
Firmware(Release)      5.0
Firmware(Incremental)  eng.cltbld.20150308.192431
Firmware Date          Sun Mar  8 19:24:47 EDT 2015
Bootloader             HHZ12d

Comment 4

[Shine(Leave from Mozilla)]

Attachment: logcat

Comment 5

[Alberto Pastor [:albertopq]]

Hi Alissa,

Is this still happening in the flame 3.0? If so, how many SIM's are you using? In which slot? Is that happening with all the carriers? Sorry for so many questions. I'm not able to repro it so far.

Thanks!

Comment 6

[Alissa（leave from Mozilla）]

(In reply to Alberto Pastor [:albertopq] from comment #5)
> Hi Alissa,
> 
> Is this still happening in the flame 3.0? If so, how many SIM's are you
> using? In which slot? Is that happening with all the carriers? Sorry for so
> many questions. I'm not able to repro it so far.
> 
> Thanks!

No, this issue doesn't exist on flame3.0, it's Nexus5 issue.

Comment 7

[Alberto Pastor [:albertopq]]

Sorry, I was confused by:

> [8.Note]:
> This issue does not exist on Flame 2.2.

I understood that it doesn't exist on Flame 2.2 but it does on 3.0. I'll try to find a Nexus 5.

Thanks!

Comment 8

[Alberto Pastor [:albertopq]]

It seems that it takes more time in the Nexus 5 to unlock the SIM. Asking UX input here. Francis, what should we do in the meanwhile the PIN is being checked? Right now we are clearing the input field only (which I agree is a little bit confusing), and closing the dialog when the PIN has been checked as correct.

Note that if is not correct, it will show the error message in the same SIM PIN dialog.

Comment 9

[Francis Djabri [:djabber]]

(In reply to Alberto Pastor [:albertopq] from comment #8)
> It seems that it takes more time in the Nexus 5 to unlock the SIM. Asking UX
> input here. Francis, what should we do in the meanwhile the PIN is being
> checked? Right now we are clearing the input field only (which I agree is a
> little bit confusing), and closing the dialog when the PIN has been checked
> as correct.
> 
> Note that if is not correct, it will show the error message in the same SIM
> PIN dialog.

Hi Alberto, 

I'd recommend that we don't clear the input field and show an inline activity indicator in the PIN field while the PIN is being checked. You can see an example of the inline activity indicator in the Messages app in conversation bubbles while an SMS is being sent. Let me know if that's enough detail, or if you need some wireframes.

Comment 10

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1139308-empty-PIN > mozilla-b2g:master

Comment 11

[Alberto Pastor [:albertopq]]

Alissa, could you please check if the patch I just attached helps to solve the problem? You should see the input being disabled (but not cleared) while checking if is correct. Thanks!

Comment 12

[Alberto Pastor [:albertopq]]

Shine, as you were also checking this issue, could you try the patch I provided? Thanks!

Comment 13

[Shine(Leave from Mozilla)]

Hi Alberto,
I will check this issue after downloading the patch. Thanks~

Comment 14

[Shine(Leave from Mozilla)]

(In reply to Alberto Pastor [:albertopq] from comment #12)
> Shine, as you were also checking this issue, could you try the patch I
> provided? Thanks!

Hi Alberto,
This problem cannot be repro with the patch in comment 10. After input passcode and tap "OK" button, the passcode view and keyboard will be hidden immediately.
See attachment: Video_N5v2.2.MP4
Rate: 0/5

N5 v2.2 build:
Build ID               20150319230147
Gaia Revision          c8136ef4094fc5509551ab7b1d5f6141491f00ef
Gaia Date              2015-03-20 01:40:54
Gecko Revision         n/a
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.0
Firmware(Incremental)  eng.rose64.20150319.223154
Firmware Date          Thu Mar 19 22:32:41 EDT 2015
Bootloader             HHZ12d

Comment 15

[Shine(Leave from Mozilla)]

Attachment: Video_N5v2.2.MP4

Comment 16

[Shine(Leave from Mozilla)]

Per comment 14, clear NI.

Comment 17

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8578612 [details] [review]
[gaia] albertopq:1139308-empty-PIN > mozilla-b2g:master

Overall it's good idea, but enable()/disable() simLockDialog seems to turn on/off the whole dialog to me. Let's use enableInput()/disableInput() instead. Thanks!

Comment 18

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1139308-empty-PIN-2 > mozilla-b2g:master

Comment 19

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/f72d2640f4be3583ac4b476ec07b6cc2bf5e8665

Comment 20

[Hermes Cheng (inactive after July 27, 2015)]

Please uplift to v2.2, thanks.

Comment 21

[Alberto Pastor [:albertopq]]

Comment on attachment 8578612 [details] [review]
[gaia] albertopq:1139308-empty-PIN > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):-
[User impact] if declined: there is no feedback between entering the PIN number, and the pin being verified, so the user will see an empty pin dialog 
[Testing completed]: added unit tests
[Risk to taking this patch] (and alternatives if risky): this is the alternative with lower risk in order to fix the issue. It just consists on disabling the input (without clearing it) before hiding the dialog.
[String changes made]: -

Comment 22

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/1e4a9ce3f3a793822b71d34b959430b1a980f0c6

Comment 23

[Shine(Leave from Mozilla)]

Attachment: video

This problem is verified pass on latest build of N5 v2.2 and v3.0.
Actual result: After input passcode and tap "OK" button, the passcode view and keyboard will be hidden immediately.
See attachment: Verify_video2.MP4
Rate: 0/10

Device: Nexus5 2.2 (Pass)
Build ID               20150327162502
Gaia Revision          473cd63f53c855299b719285d9b95e3f2910782f
Gaia Date              2015-03-27 20:14:43
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/b358619def45
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.0
Firmware(Incremental)  eng.cltbld.20150327.195950
Firmware Date          Fri Mar 27 20:00:03 EDT 2015
Bootloader             HHZ12d

Nexus5 3.0 (Pass)
Build ID               20150327160203
Gaia Revision          9cc496cecc37d7a29f9279827cdf6e4891211f67
Gaia Date              2015-03-27 13:55:18
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/44e454b5e93b
Gecko Version          39.0a1
Device Name            hammerhead
Firmware(Release)      5.0
Firmware(Incremental)  eng.cltbld.20150327.192727
Firmware Date          Fri Mar 27 19:27:40 EDT 2015
Bootloader             HHZ12d