Closed
Bug 1139343
Opened 9 years ago
Closed 9 years ago
Change existing setBoolPrefs to pushPrefEnv
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: anishchandran94, Assigned: johnkang.h, Mentored)
Details
Attachments
(1 file, 1 obsolete file)
3.53 KB,
patch
|
martijn.martijn
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 Build ID: 20140715214327 Steps to reproduce: https://dxr.mozilla.org/mozilla-central/search?limit=100&redirect=false&q=SpecialPowers.setBoolPref%20path%3Alayout%2F https://dxr.mozilla.org/mozilla-central/search?limit=100&redirect=false&q=SpecialPowers.setBoolPref%20path%3Adom/mobilemessage%2F https://dxr.mozilla.org/mozilla-central/search?limit=100&redirect=false&q=SpecialPowers.setBoolPref%20path%3Adom/tests%2F
Updated•9 years ago
|
QA Whiteboard: [bugday-20150309]
Component: Untriaged → General
Flags: needinfo?(martijn.martijn)
Flags: needinfo?(jmaher)
Product: Firefox → Core
Comment 1•9 years ago
|
||
Thanks Anish for filing this. These above mentioned queries will get about half of the remaining api's converted.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(martijn.martijn)
Flags: needinfo?(jmaher)
Hello, I would like to take on this bug if it hasn't been fixed yet.
Comment 3•9 years ago
|
||
John, that would be great! Let me know if you need help, I'm available on irc/email/etc.
Assignee: nobody → johnkang.h
Here is the first fix. Please let me know if it was done correctly/needs more.
Flags: needinfo?(martijn.martijn)
Comment 5•9 years ago
|
||
(In reply to John Kang from comment #4) > Created attachment 8585105 [details] [diff] [review] > bug1139343.diff (for test_selectioncarets.py) > > Here is the first fix. Please let me know if it was done correctly/needs > more. This is perfect, thanks.
Flags: needinfo?(martijn.martijn)
Here's the patch!
Attachment #8585105 -
Attachment is obsolete: true
Comment 7•9 years ago
|
||
Comment on attachment 8585246 [details] [diff] [review] bug1139343.diff Review of attachment 8585246 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, this part looks good. Try server results here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5dcafbc653ac
Attachment #8585246 -
Flags: review+
Comment 8•9 years ago
|
||
I removed the SpecialPower usage for the selection-carets marionette tests in bug 1163490. We do need to land the patch in this bug.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•