1139674 - Uploading large add-on causes standalone validator to break

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Description

[Jorge Villalobos [:jorgev] (he/him)]

Attachment: validatorerror.png

STR:
Validate large add-on file on https://addons.mozilla.org/en-US/developers/addon/validate 

Observed result:

See attached screenshot. The amount of warnings found is shown, but the checklist section is broken and there's no link to the validation results.

I need to confirm with the reporter that it's okay to share the file for testing on this bug. I will email it otherwise.

Comment 1

[Danil Ivanov]

Files:
http://imfo.ru/transit/[e-mail] ("no errors and 764 messages")
http://imfo.ru/transit/[e-mail] ("no errors and 4684 messages")

Comment 2

[Mathieu Agopian [:magopian]]

Mark, any clue?

Comment 3

[Mathieu Agopian [:magopian]]

Just wondering if it could be linked to https://bugzilla.mozilla.org/show_bug.cgi?id=1135471 (:jason?)

Comment 4

[Mark Striemer [:mstriemer]]

The upload-addon.js code tries to populate that checklist [1] based on some warnings. It goes through each message in `results.validation.messages` and checks its `id` which _should_ be an array like `["testcases_javascript_instanceactions", "_call_expression", "createelement_variable"]` (lifted from a comment in the code).

When there are more than 500 messages however the list is truncated to 499 and a message is added to the end describing the truncation. This message does not have an `id` [2] and things explode inside of underscore [3].

This probably should handle a message without an `id`, also that message should have an `id`.

[1] https://github.com/mozilla/olympia/blob/master/static/js/common/upload-addon.js#L355-L364
[2] https://github.com/mozilla/olympia/blob/master/apps/devhub/utils.py#L54-L62
[3] https://github.com/mozilla/olympia/blob/master/static/js/common/upload-addon.js#L344

Comment 5

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/olympia/pull/475

Comment 6

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/828a4cb7e6486d350fd17ed17789c9029edf3e26

STR: download the addons from comment 1 and try to submit them on the standalone validation page (/developers/addon/validate). It should properly display the messages (checklist, link to full report...)

Comment 7

[Valentina Virlics [:vvalentina], Ecosystem QA]

Verified as fixed on AMO-dev on FF38(Win 7) for the first addon from comment #1.
Postfix screencast: http://screencast.com/t/mDQdQ5wJ  

For the second addon, I get the message: http://screencast.com/t/kqC0x4Bw. 
It displays the link to full report, but has errors; this is how it should be?
Thanks!

Comment 8

[Mathieu Agopian [:magopian]]

I'm not sure about the validation timeout, but the second message is correct yes (the number of messages being truncated).

Comment 9

[Kris Maglione [:kmag]]

The timeout is intended, yes.

Comment 10

[Valentina Virlics [:vvalentina], Ecosystem QA]

According to comment #8 and comment #9 the issue was verified as fixed on AMO-dev on FF38(Win 7).
The postfix screencast it's above.
Closing bug.