1139899 - Mark as read notifications for the visible question

Status: VERIFIED FIXED

(support.mozilla.org :: BuddyUp, defect)

Description

[Anthony Ricaud (:rik)]

STR:
1) On device A, open question 5
2) On device B, answer to question 5
3) Device A will show the new answer but won't display a notification
4) On device A, quit the application
5) On device B, answer to question 6

Actual:
Device A receives notifications for question 5 and 6.

Expected:
Device B receives notifications for question 6.

Comment 1

[Anthony Ricaud (:rik)]

This is because in step 3, we don't mark notifications for question 5 as read.

Although it could be annoying, I don't think this is a blocker for release.

Comment 2

[Kadir Topal [:atopal]]

I don't get it. Why do you expect Device B to get a notification? Isn't that the one who sent the message in the first place? It seems like the issue is that device A is receiving all messages as notifications still, but only when the user closes the app?

This shouldn't lead to too much confusion for helpees. People don't go around asking question after question, but it might be a major annoyance for helpers.

Comment 3

[Anthony Ricaud (:rik)]

Sorry, the expected part should read "Device A receives notifications for question 6."

Comment 4

[Kadir Topal [:atopal]]

We discussed this last week. Decision: We designate this not a release blocker for now. If testing shows this to be more annoying than expected we will reevaluate.

Comment 6

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla/buddyup/pull/152

Comment 7

[Anthony Ricaud (:rik)]

https://github.com/mozilla/buddyup/commit/e34cd7be271855bcbb68b2b3790e141344402bf0