Closed Bug 1139983 Opened 9 years ago Closed 9 years ago

Do not fall back to tenured if we fail to allocate in the nursery when NoGC

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

We have a hugely complicated infrastructure around allocation for the new object cache to allow us to clear the nursery when it fills up without clobbering the cache itself. This is dumb. Unlike with CanGC, where failure usually kills the script, when we're allocating with NoGC, we're already prepared to retry on failure, so making a best effort makes no sense. If we just return false on nursery alloc failure, we have an insubstantially lower hit rate, but we can dump the enormous complexity.

Try run looks green modulo 2 cgc failures -- a missing annotation in the previous patch -- and what looks like a random orange -- I've retriggered a few runs to check:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=73c6c968bbb3
Attachment #8573337 - Flags: review?(bhackett1024)
Attachment #8573337 - Flags: review?(bhackett1024) → review+
https://hg.mozilla.org/mozilla-central/rev/9a2b3b8289ee
Assignee: nobody → terrence
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: