1140088 - bootstrap.py gives incorrect git URL

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

<gps> bsmedberg: you should use mozilla/gecko-dev on github
<gps> or https://git.mozilla.org/?p=releases/gecko.git;a=summary

Easy to patch, but I'd like a definitive answer about the correct URL.

Comment 1

[Gregory Szorc [:gps]]

https://git.mozilla.org/?p=releases/gecko.git;a=summary and https://github.com/mozilla/gecko-dev are produced by the same tool. Aside from a very small window between `git push` invocations, the contents should be identical.

Personally, I prefer 3rd parties take hosting responsibilities away from us. Scaling Git servers is hard. I'm happy to advertise github.com as the default URI.

Comment 2

[Luis de Bethencourt [:luisbg]]

People running bootstrap.py for the first time and looking for the mozilla-central source code might try the git option listed: "git clone https://git.mozilla.org/integration/gecko-dev.git" which fails to find the repository.

This site [0] lists git.mozilla.org as decommissioned.

A google search will point to github.com/mozilla/gecko-dev, but it might be worth it to update the print out of bootstrap.py. Since starting to experience of playing with gecko code with a failure is not very welcoming.

I am happy to offer the patch, just proposing the fix here first before I do so to make sure it would be accepted.

Thanks for the review and help :)


[0] https://wiki.mozilla.org/DeveloperServices/HistoricalVCS

Comment 3

[Nathan Froyd [:froydnj]]

(In reply to Luis de Bethencourt [:luisbg] from comment #2)
> I am happy to offer the patch, just proposing the fix here first before I do
> so to make sure it would be accepted.

Please do!

Comment 4

[Luis de Bethencourt [:luisbg]]

Attachment: 1140088.patch

Here is the patch.

I haven't submitted a patch to mozilla-central in a long time, so please let me know if you need anything from me besides attaching the patch here and waiting for review.

Thanks :)

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8861405 [details] [diff] [review]
1140088.patch

Review of attachment 8861405 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9fc5b6124839
Update git URL to github; r=froydnj

Comment 7

[Luis de Bethencourt [:luisbg]]

Thanks for the review and push Nathan! :)

Comment 8

[Nathan Froyd [:froydnj]]

No problem!

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9fc5b6124839

Comment 10

[Luis de Bethencourt [:luisbg]]

Ooops I should've changed the status to Resolved. Now I know for next time.

Thanks Wes :)

Comment 11

[Nathan Froyd [:froydnj]]

(In reply to Luis de Bethencourt [:luisbg] from comment #10)
> Ooops I should've changed the status to Resolved. Now I know for next time.
> 
> Thanks Wes :)

Setting the bug status to RESOLVED only happens when the commits are merged to central; that's why Wes is setting the status, not because of anything you forgot to do. :)