Closed
Bug 1140092
Opened 9 years ago
Closed 9 years ago
Remove old call url reception code from the Loop backend
Categories
(Hello (Loop) :: Client, defect, P2)
Hello (Loop)
Client
Tracking
(firefox39 fixed)
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Whiteboard: [tech-debt])
Attachments
(1 file, 1 obsolete file)
27.67 KB,
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1121071 +++ Split out from bug 1120171 as crosses multiple releases. Now that we're shipping rooms, we don't need the old call url generation code. Parts to be removed: - Anything in MozLoopService/MozLoopAPI no longer used, e.g. -- noteCallUrlExpiry -- (possibly other things)
Assignee | ||
Updated•9 years ago
|
Flags: qe-verify?
Flags: firefox-backlog+
Assignee | ||
Comment 1•9 years ago
|
||
This doesn't quite work yet - one of the xpcshell tests is failing, parking here so that I can take a look at it in a different view and so that it doesn't get lost.
Assignee | ||
Comment 2•9 years ago
|
||
Finally worked out what I'd done wrong on one of the promises. This is now ready for review.
Attachment #8573473 -
Attachment is obsolete: true
Attachment #8573569 -
Flags: review?(mdeboer)
Comment 3•9 years ago
|
||
Comment on attachment 8573569 [details] [diff] [review] Remove handling of guest calls from the Loop backend. Review of attachment 8573569 [details] [diff] [review]: ----------------------------------------------------------------- LGTM! I think it's important to push this to Try first (with xpcshell and mochitest enabled) to see if you caught all the things. ::: browser/components/loop/test/xpcshell/head.js @@ +28,5 @@ > var loopServer; > > // Ensure loop is always enabled for tests > Services.prefs.setBoolPref("loop.enabled", true); > +Services.prefs.setCharPref("loop.debug.loglevel", "All"); Why is it necessary to set this pref now?
Attachment #8573569 -
Flags: review?(mdeboer) → review+
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to Mike de Boer [:mikedeboer] from comment #3) > LGTM! I think it's important to push this to Try first (with xpcshell and > mochitest enabled) to see if you caught all the things. Well if not, ./browser/components/loop/run-all-loop-tests.sh is broken ;-) But I'll push anyway just in case. > @@ +28,5 @@ > > var loopServer; > > > > // Ensure loop is always enabled for tests > > Services.prefs.setBoolPref("loop.enabled", true); > > +Services.prefs.setCharPref("loop.debug.loglevel", "All"); > > Why is it necessary to set this pref now? It isn't, I was struggling with debugging and it was something I was using for more debug.
Assignee | ||
Comment 5•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f48861cd09bd
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/95efe38a63d6
Target Milestone: --- → mozilla39
Assignee | ||
Updated•9 years ago
|
Flags: qe-verify? → qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•